Improvements & refactoring of get_file_contents #1582
+62
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the get_file_contents tool to eliminate the requirement for directory paths to end with a trailing slash. The refactoring unifies the code path for both files and directories by first calling the GitHub Contents API to determine the type, then proceeding accordingly.
Key Changes:
- Removed the trailing slash requirement from the path parameter description
- Unified the GetContents API call for both files and directories instead of having separate conditional logic
- Simplified control flow by checking the response type (file vs directory) after the API call rather than before
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/github/repositories.go | Refactored GetFileContents function to remove trailing slash dependency and unify the API call path for files and directories; updated parameter description |
| pkg/github/toolsnaps/get_file_contents.snap | Updated tool schema snapshot to reflect the changed path parameter description |
tommaso-moro
previously approved these changes
Dec 12, 2025
Contributor
tommaso-moro
left a comment
There was a problem hiding this comment.
left a comment but otherwise lgtm!
SamMorrowDrums
previously approved these changes
Dec 12, 2025
f4a7585
f4a7585 to
a3460a9
Compare
tommaso-moro
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains refactoring of get_file_contents tool that eliminates error
file content SHA is nil, if a directory was requested, path parameters should end with a trailing slash '/'We shouldn't fail when trailing slash is not supplied. Also, for both directories and files the same API call is being used, therefore there's no need for two separate logical paths.
I removed the reliance on trailing slash and branching related to it. Instead, if GetContents returns directory content - we return it, if it is a file - we proceed with downloading etc.