🌐 AI搜索 & 代理 主页
Skip to content

fix: transaction_tag should be set on BeginTransactionRequest #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
surbhigarg92 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: transaction_tag should be set on BeginTransactionRequest #1463

surbhigarg92 wants to merge 1 commit into from
+30 −6

Conversation

@surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented Dec 11, 2025

When using multiplexed sessions, the transaction_tag should also be set on the BeginTransactionRequest.

@surbhigarg92 surbhigarg92 requested review from a team as code owners December 11, 2025 05:55
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 11, 2025
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Dec 11, 2025
@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 11, 2025

Summary of Changes

Hello @surbhigarg92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the transaction_tag was not being included in BeginTransactionRequest when utilizing multiplexed sessions. By modifying the _begin_transaction method and its callers, the transaction_tag is now properly propagated, ensuring correct transaction management and tracing for multiplexed sessions.

Highlights

  • BeginTransactionRequest Update: The _begin_transaction method in google/cloud/spanner_v1/snapshot.py now accepts an optional transaction_tag parameter.
  • Transaction Tag Propagation: The transaction_tag is now correctly propagated within a RequestOptions object to the BeginTransactionRequest in google/cloud/spanner_v1/snapshot.py.
  • Transaction Class Integration: The Transaction class in google/cloud/spanner_v1/transaction.py now forwards its transaction_tag to the underlying _begin_transaction call.
  • Test Coverage: Unit tests in tests/unit/test_transaction.py have been updated to verify the correct handling of transaction_tag in BeginTransactionRequest.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 11, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where the transaction_tag was not being set on BeginTransactionRequest, which is crucial for multiplexed sessions. The changes correctly introduce the transaction_tag parameter to the _begin_transaction method and ensure it's passed when creating the request. The fix is logical, and the accompanying test updates properly validate the new behavior. I've included a couple of minor suggestions to improve code conciseness.

sakthivelmanii
sakthivelmanii previously approved these changes Dec 11, 2025
View reviewed changes
@surbhigarg92 surbhigarg92 force-pushed the add_transaction_tag_begin branch from 28d781e to 89e1b36 Compare December 11, 2025 06:52
sakthivelmanii
sakthivelmanii reviewed Dec 11, 2025
View reviewed changes
sakthivelmanii
sakthivelmanii reviewed Dec 11, 2025
View reviewed changes
@surbhigarg92 surbhigarg92 force-pushed the add_transaction_tag_begin branch from 89e1b36 to eb03c32 Compare December 11, 2025 07:15
@surbhigarg92 surbhigarg92 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2025
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Dec 12, 2025

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakthivelmanii sakthivelmanii sakthivelmanii left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@bhatt4982 bhatt4982

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@surbhigarg92 @sakthivelmanii @bhatt4982