build: support go:embed #1153
Merged
build: support go:embed #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nevkontakte
approved these changes
Sep 21, 2022
Member
|
For the posterity, the original PR is #1145. I've no idea why CircleCI is not running in this or the original PR. AFAICT it should run for all PRs from forked repositories. @visualfc any chance that you have some sort of special setup for your fork? 😕 In any case, I ran the stdlib tests locally and they have passed, and I think the CI should trigger post-merge as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support go:embed
dep pkg github.com/visualfc/goembed
Fixes #997