Replace Tuya remap methods with helper class #158718
Merged
+174
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Tuya integration's value remapping functionality by introducing a new RemapHelper class to replace the previous confusing methods. The changes improve code clarity by making source and target ranges explicit, converting reverse to a keyword-only argument, and eliminating fake IntegerTypeInformation instances that were previously created just to access helper methods.
Key changes:
- Introduced
RemapHelperdataclass with explicit source/target ranges and factory methods - Replaced
IntegerTypeInformation.remap_value_to/frommethods withRemapHelperinstances - Made
type_datafield non-optional inTypeInformationclass since it's always provided
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/tuya/util.py | Added new RemapHelper dataclass with remap_value_to, remap_value_from, and static remap_value methods; includes factory methods for creating instances from type information or function data |
| homeassistant/components/tuya/type_information.py | Removed remap_value_to and remap_value_from methods from IntegerTypeInformation; changed type_data from optional to required field |
| homeassistant/components/tuya/light.py | Replaced fake IntegerTypeInformation instances with RemapHelper instances for HSV defaults; updated brightness, color temperature, and color data wrappers to use RemapHelper |
| homeassistant/components/tuya/fan.py | Updated _FanSpeedIntegerWrapper to use RemapHelper instance for value remapping |
| homeassistant/components/tuya/cover.py | Updated _DPCodePercentageMappingWrapper to use RemapHelper instance; contains import error (uses .utils instead of .util) |
joostlek
approved these changes
Dec 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The current remap methods are confusing:
0-100in cover,1-100in fan,0-360/0-100/0-255/MIN_MIREDS-MAX_MIREDSin light) were passed in bothremap_value_fromandremap_value_toIntegerTypeInformationclasses in order to access the helper method thereThis replaces the current methods with a helper class so that:
IntegerTypeInformationinstances are replaced withRemapHelperinstancesType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: