fix: kd-tree fix + test speedup #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neighbors_kd_tree_fix
|
✔️ Deploy Preview for scikitjs ready! 🔨 Explore the source changes: 5f681ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/scikitjs/deploys/61f1cdbb276fca00087a3c17 😎 Browse the preview: https://deploy-preview-194--scikitjs.netlify.app |
dcrescim
approved these changes
Jan 27, 2022
Collaborator
dcrescim
left a comment
There was a problem hiding this comment.
Looks good @DirkToewe . 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbeknownst to me,
.dataSync()may or may not return the underlying data array of aTensor. This led to a subtle bug in theKdTreeimplementation. The protection copy added by this PR should fix that. PR also includes:KdTreeandBruteNeighborhoodsrc/neighbors/*test speedupKNeighborsClassifiercan now be instantiated without parameters.KNeighborsBase.SUPPORTED_ALGORITHMSlists all available algorithms for testing convenience.