feat: custom modelfitargs for linear models #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scikitjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
Looks great @yawetse . It seems if you want to create a custom callback, you have to wrap it in tf.customCallback. I didn't realize this either until I found this issue, and this stackoverflow post. I added test cases to make sure it works, and serializes well. |
Collaborator
Author
|
Wow! Great find thank you!
Gotta love undocumented APIs, hah
…Sent from my iPhone
On May 19, 2022, at 00:43, Dan Crescimanno ***@***.***> wrote:
Looks great @yawetse . It seems if you want to create a custom callback, you have to wrap it in tf.customCallback. I didn't realize this either until I found this issue (tensorflow/tfjs#1792), and this stackoverflow post (https://stackoverflow.com/questions/58116087/tensorflowjs-with-earlystopping-and-training-logs-does-not-work). I added test cases to make sure it works, and serializes well.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.