Cleanup displayName type
#10049
Merged
Cleanup displayName type
#10049
+12
���20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce98b74 to
a51abe3
Compare
Codecov Report
@@ Coverage Diff @@
## master #10049 +/- ##
==========================================
+ Coverage 64.00% 64.01% +0.01%
==========================================
Files 297 297
Lines 12528 12524 -4
Branches 3093 3088 -5
==========================================
- Hits 8018 8017 -1
+ Misses 3860 3858 -2
+ Partials 650 649 -1
Continue to review full report at Codecov.
|
SimenB
approved these changes
May 16, 2020
Member
SimenB
left a comment
There was a problem hiding this comment.
I think this covers it, thanks! Just a changelog entry and we can merge 🙂
a51abe3 to
6d1b685
Compare
SimenB
approved these changes
May 19, 2020
Member
|
Thanks! |
jeysal
added a commit
to jeysal/jest
that referenced
this pull request
May 25, 2020
…esolve-outside * upstream/master: (106 commits) docs: fix jest-diff example (jestjs#10067) Cleanup `displayName` type (jestjs#10049) docs: correct confusing filename in `enableAutomock` example (jestjs#10055) chore: minor optimize getTransformer (jestjs#10050) chore: fix TestUtils.ts to match the types (jestjs#10034) Minor test name typo fix (jestjs#10033) chore: upgrade to typescript 3.9 (jestjs#10031) feat: CLI argument to filter tests by projects (jestjs#8612) chore: bump `istanbul-lib-instrument` (jestjs#10009) feat: support config files exporting (`async`) `function`s (jestjs#10001) fix: add missing haste-map dep to jest-snapshot (jestjs#10008) 🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 (jestjs#10000) Fix typo in dependency warning (jestjs#10006) chore: add missing comma (jestjs#9999) fix: Control no diff message color with diff options (jestjs#9997) fix(jest-jasmine2): fix Error message (jestjs#9990) docs: fix jest-object ids for docusaurs (jestjs#9994) docs: fix Configuration, JestPlatform and JestObjectAPI docs for 26 (jestjs#9985) Add migration notes for breaking changes (jestjs#9978) chore: fix date and heading in blog post (jestjs#9977) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10010
If I understand correctly, the type of
displayNameinProjectConfigtype cannot be a string because it has been normalized, therefore I remove thestringtype in theDisplayNametype. SinceInitialOptionscan still take instringI add it back there.The rest is to change the places where
displayNameis treated asstring(i.e. remove such codes because it will never happen)TODOs:
Test plan
Check CI results 😅