jQuery.globalEval: Document the document parameter #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since jQuery 3.5.0, jQuery.globalEval accepts an optional third parameter accepting a document in which context the code will be evaluated. This commit also adds the Document type and links it to one of the jQuery signatures; so far it was using `type="document"` which linked to a non-existent types section. Ref jquery/jquery#4601
dmethvin
approved these changes
Jul 19, 2020
timmywil
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jQuery 3.5.0,
jQuery.globalEvalaccepts an optional third parameteraccepting a document in which context the code will be evaluated.
This commit also adds the Document type and links it to one of the jQuery
signatures; so far it was using
type="document"which linked to a non-existenttypes section.
Ref jquery/jquery#4601