Core: Remove private copies of push, sort & splice from the jQuery prototype

mgol · web-flow · commit b59107f5d745 · 2019-09-24T02:12:36.000+02:00
Closes gh-4473
diff --git a/src/core.js b/src/core.js
@@ -120,13 +120,7 @@ jQuery.fn = jQuery.prototype = {
 
 	end: function() {
 		return this.prevObject || this.constructor();
-	},
-
-	// For internal use only.
-	// Behaves like an Array's method, not like a jQuery method.
-	push: push,
-	sort: arr.sort,
-	splice: arr.splice
+	}
 };
 
 jQuery.extend = jQuery.fn.extend = function() {
diff --git a/src/selector.js b/src/selector.js
@@ -190,7 +190,7 @@ function find( selector, context, results, seed ) {
 					// Document context
 					if ( nodeType === 9 ) {
 						if ( ( elem = context.getElementById( m ) ) ) {
-							results.push( elem );
+							push.call( results, elem );
 						}
 						return results;
 
@@ -199,7 +199,7 @@ function find( selector, context, results, seed ) {
 						if ( newContext && ( elem = newContext.getElementById( m ) ) &&
 							jQuery.contains( context, elem ) ) {
 
-							results.push( elem );
+							push.call( results, elem );
 							return results;
 						}
 					}
@@ -1426,7 +1426,7 @@ function matcherFromGroupMatchers( elementMatchers, setMatchers ) {
 					}
 					while ( ( matcher = elementMatchers[ j++ ] ) ) {
 						if ( matcher( elem, context || document, xml ) ) {
-							results.push( elem );
+							push.call( results, elem );
 							break;
 						}
 					}
diff --git a/src/selector/uniqueSort.js b/src/selector/uniqueSort.js
@@ -1,7 +1,8 @@
 define( [
 	"../core",
-	"../var/document"
-], function( jQuery, document ) {
+	"../var/document",
+	"../var/sort"
+], function( jQuery, document, sort ) {
 
 "use strict";
 
@@ -61,7 +62,7 @@ jQuery.uniqueSort = function( results ) {
 
 	hasDuplicate = false;
 
-	results.sort( sortOrder );
+	sort.call( results, sortOrder );
 
 	if ( hasDuplicate ) {
 		while ( ( elem = results[ i++ ] ) ) {
diff --git a/src/var/sort.js b/src/var/sort.js
@@ -0,0 +1,7 @@
+define( [
+	"./arr"
+], function( arr ) {
+	"use strict";
+
+	return arr.sort;
+} );

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ function find( selector, context, results, seed ) {`
`190`	`190`	`// Document context`
`191`	`191`	`if ( nodeType === 9 ) {`
`192`	`192`	`if ( ( elem = context.getElementById( m ) ) ) {`
`193`		`- results.push( elem );`
	`193`	`+ push.call( results, elem );`
`194`	`194`	`}`
`195`	`195`	`return results;`
`196`	`196`
`@@ -199,7 +199,7 @@ function find( selector, context, results, seed ) {`
`199`	`199`	`if ( newContext && ( elem = newContext.getElementById( m ) ) &&`
`200`	`200`	`jQuery.contains( context, elem ) ) {`
`201`	`201`
`202`		`- results.push( elem );`
	`202`	`+ push.call( results, elem );`
`203`	`203`	`return results;`
`204`	`204`	`}`
`205`	`205`	`}`
`@@ -1426,7 +1426,7 @@ function matcherFromGroupMatchers( elementMatchers, setMatchers ) {`
`1426`	`1426`	`}`
`1427`	`1427`	`while ( ( matcher = elementMatchers[ j++ ] ) ) {`
`1428`	`1428`	`if ( matcher( elem, context \|\| document, xml ) ) {`
`1429`		`- results.push( elem );`
	`1429`	`+ push.call( results, elem );`
`1430`	`1430`	`break;`
`1431`	`1431`	`}`
`1432`	`1432`	`}`