🌐 AI搜索 & 代理 主页
Skip to content

Core: Remove private copies of push, sort & splice from the jQuery prototype #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Sep 24, 2019
Merged

Core: Remove private copies of push, sort & splice from the jQuery prototype #4473

mgol merged 1 commit into from
Sep 24, 2019

Conversation

@mgol
Copy link
Member

@mgol mgol commented Aug 29, 2019

Summary

Remove private copies of push, sort & splice from the jQuery prototype. Saves 13 bytes.

Checklist

@mgol mgol added this to the 4.0.0 milestone Aug 29, 2019
@mgol mgol self-assigned this Aug 29, 2019
timmywil
timmywil approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 4.0

@mgol mgol force-pushed the push-sort-splice branch from 44613bb to 815d8f5 Compare August 30, 2019 23:53
@mgol mgol merged commit b59107f into jquery:master Sep 24, 2019
@mgol mgol deleted the push-sort-splice branch September 24, 2019 00:12
@mgol mgol removed the Needs review label Sep 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

Core

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil