🌐 AI搜索 & 代理 主页
Skip to content

Handle the case of an empty string. Fixes #13401 #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markraddatz wants to merge 2 commits into from
Closed

Handle the case of an empty string. Fixes #13401 #1162

markraddatz wants to merge 2 commits into from

Conversation

@markraddatz
Copy link
Contributor

@markraddatz markraddatz commented Feb 6, 2013

This will fix .replaceWith() when you pass an empty string.

jaubourg
jaubourg reviewed Feb 6, 2013
View reviewed changes
src/manipulation.js Outdated
Copy link
Member

@jaubourg jaubourg Feb 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not elem === "" instead?

Copy link
Contributor

@staabm staabm Feb 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test also handles the case of " ", which wouldn't work with elem === ""

Copy link
Member

@jaubourg jaubourg Feb 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but would have been caught by elem since !!" " === true.

Copy link
Contributor Author

@markraddatz markraddatz Feb 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elem === "" should work as well.

gibson042
gibson042 reviewed Feb 7, 2013
View reviewed changes
src/manipulation.js
Copy link
Member

@gibson042 gibson042 Feb 7, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-3 bytes by changing this condition to elem != null && elem !== false.

@gibson042
Copy link
Member

gibson042 commented Feb 7, 2013

I approve of this pull, but it changes the behavior of other manipulation methods (append/prepend/before/after and *To/insert* inversions) and thus may not be fit for a patch release. But there is a regression with respect to 1.8 replaceWith, so maybe we should special-case "" or something (I'm open to suggestion on that).

@markraddatz
Copy link
Contributor Author

markraddatz commented Feb 7, 2013

From this perspective I totally agree that the change causes more harm than good. I prefer to have a lean childNodes list without clutters of empty strings. I opt in for a solution that uses the 1.8 replaceWith way without domManip.

@gibson042
Copy link
Member

gibson042 commented Feb 7, 2013

@markraddatz Do you want to submit another pull request with that approach? I'd suggest keeping the .domManip dependency but just adding a value === "" check in .replaceWith that either redefines value or (probably better) skips .domManip in favor of .remove.

@markraddatz
Copy link
Contributor Author

markraddatz commented Feb 7, 2013

I submitted a new pull request that skips .domManip for this special case.

@dmethvin
Copy link
Member

dmethvin commented Feb 7, 2013

Closing in favor of gh-1163.

@dmethvin dmethvin closed this Feb 7, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markraddatz @gibson042 @dmethvin @staabm @jaubourg