Offset: simplify jQuery#offsetParent method #1968
Conversation
There was a problem hiding this comment.
These exceptions would be better to put in the documentation too or instead of
There was a problem hiding this comment.
If these are pathological cases that don't occur in real life, I am not sure why we are commenting them anyway. The result might change in a refactoring and these comments would no longer be true, but people might have read them as documented and supported.
There was a problem hiding this comment.
How about i will add a notice about it, like "But this is undefined and undocumented behavior, could be changed at any point" or something like that.
It feels weird to know about these edge cases, but not put some info about them somewhere.
There was a problem hiding this comment.
It really does seem like this is documentation. I am okay with putting a comment like "this is not guaranteed" nearby though and we can hope we don't need to change it.
* It seems, check for html element (and previously for body element) was redundant * Simplify "return" statement * Add comment about potential errors that didn't find themselves in real life app
e92a6ee to
32ce635
Compare
|
Seems like this should address gh-1765 as well since that will change the same code. |
* It seems, check for html element (and previously for body element) was redundant * Simplify "return" statement * Add comment about potential errors that didn't find themselves in real life app Closes gh-1968
was redundant
This code would work even in IE6 quirks mode