🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@agcolom
Copy link
Member

@agcolom agcolom commented Jan 1, 2015

I'm not too sure about the change in Gruntfile.js, so please let me know if you would like it to be different, e,g, whether the jquery.org/license should be on the same line as the Copyright notice, whether it should be https://jquery.org/ or https://jquery.org/license also, or anything else.

Gruntfile.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from (c) to Copyright? You didn't do the same in the Sizzle PR: https://github.com/jquery/sizzle/pull/307/files

This is the banner put in the minified files, e.g. https://code.jquery.com/jquery-2.1.3.min.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave | at the end, it separates the copyright info from the URL to the license (see the linked minified file for example).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzgol Thanks for the comments. I'll make the changes now.

@mgol
Copy link
Member

mgol commented Jan 1, 2015

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the intro file you also dropped the Inc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, why this is being dropped btw?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need them, according to lawyers. So removing the dates makes it easier to maintain! 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the Inc. here for consistency.

@dmethvin dmethvin self-assigned this Jan 3, 2015
dmethvin pushed a commit that referenced this pull request Jan 3, 2015
Closes gh-1983
(cherry picked from commit 66e1b6b)

Conflicts:
	Gruntfile.js
@dmethvin dmethvin closed this in 66e1b6b Jan 3, 2015
markelog pushed a commit that referenced this pull request Nov 10, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants