🌐 AI搜索 & 代理 主页
Skip to content

CSS: Add an integration test for issue gh-1764 #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol wants to merge 1 commit into from
Closed

CSS: Add an integration test for issue gh-1764 #2425

mgol wants to merge 1 commit into from

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jun 22, 2015

Refs gh-1764
Refs gh-2401

Screenshots in IE11:

  1. not fullscreen:
    screen shot 2015-06-23 at 01 42 16
  2. fullscreen without the patch:
    screen shot 2015-06-23 at 01 42 34
  3. fullscreen with the patch:
    screen shot 2015-06-23 at 01 53 59

@mgol mgol added this to the 3.0.0 milestone Jun 22, 2015
@mgol mgol mentioned this pull request Jun 22, 2015
Closed
@markelog
Copy link
Member

markelog commented Jun 24, 2015

This is ported from http://christophercurrie.github.io/technology/2014/03/20/internet-explorer-11-fullscreen-bug.html?

@mgol
Copy link
Member Author

mgol commented Jun 25, 2015

No, written from scratch. I wanted to make it as similar to the compat PATCH test as possible.

@mgol mgol force-pushed the fullscreen-integration-test branch from 25d1eca to 61a27b6 Compare June 25, 2015 01:47
@mgol
Copy link
Member Author

mgol commented Jul 6, 2015

@timmywil @markelog is it OK to land?

@markelog
Copy link
Member

markelog commented Jul 7, 2015

This probably would need to be changed anyway if/when we integrate e2e-testing, so if it works now it is LGTM.

@mgol
Copy link
Member Author

mgol commented Jul 7, 2015

I forgot: I should add another div on the page that's not in an iframe to
ensure we're correcting the output only when it's wrong. The script needs
to be extracted to avoid the duplication. I'll update the PR tomorrow.

Michał Gołębiowski

@mgol mgol force-pushed the fullscreen-integration-test branch from 61a27b6 to 3ad86bb Compare July 7, 2015 16:52
@mgol
Copy link
Member Author

mgol commented Jul 7, 2015

I refactored the test; JS & CSS are now in separate files, shared by the main HTML & the iframe one.

I also added the non-iframe test just to be sure.

@mgol
Copy link
Member Author

mgol commented Jul 7, 2015

I'll land it tomorrow around noon European time or slightly later.

@mgol mgol closed this in 8887106 Jul 8, 2015
@mgol mgol deleted the fullscreen-integration-test branch July 8, 2015 09:55
mgol added a commit that referenced this pull request Jul 8, 2015
@mgol
CSS: Add an integration test for issue gh-1764
7ee0fea 
(cherry-picked from 8887106)

Refs gh-1764
Refs gh-2401
Closes gh-2425
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mgol @markelog @timmywil @jquerybot