Core: restore enumeration behavior in isPlainObject #2970
Conversation
test/unit/core.js
Outdated
|
|
||
| // The use case that we want to match | ||
| assert.ok( jQuery.isPlainObject( {} ), "{}" ); | ||
| assert.ok( jQuery.isPlainObject( new Object() ), "new Object" ); // jshint ignore:line |
There was a problem hiding this comment.
Because of new Object(), I guess. Is that test necessary considering that it's equivalent to {} if one doesn't modify Object.prototype which we don't support?
There was a problem hiding this comment.
new window.Object? If we talking about the same thing? jshint ignore:line is bit radical, it seems we should disable the rule, not the whole thing
There was a problem hiding this comment.
Wow, that new window.Object() does work! Didn't even know why would jshint highlight that - just pointed in the sky and made it rain i guess :)
There was a problem hiding this comment.
Which a jshint bug of course :)
|
It seems |
| // |obj| is a plain object, created by {} or constructed with new Object | ||
| return true; | ||
| // Own properties are enumerated firstly, so to speed up, | ||
| // if last one is own, then all properties are own |
Nice |
Ref 00575d4 Also see discussion in #2970 (comment)
Fixes gh-2968