🌐 AI搜索 & 代理 主页
Skip to content

Core: deprecate jQuery.isFunction #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbedard merged 1 commit into from
Jan 15, 2018
Merged

Core: deprecate jQuery.isFunction #3893

jbedard merged 1 commit into from
Jan 15, 2018

Conversation

@jbedard
Copy link
Contributor

@jbedard jbedard commented Dec 18, 2017 •
edited by timmywil
Loading

Fixes gh-3609

Summary

Deprecates the public isFunction, but it is still used in many places.

Checklist

@jbedard jbedard force-pushed the 3609 branch 2 times, most recently from 74b0e44 to 9729982 Compare December 18, 2017 17:48
@mgol
Copy link
Member

mgol commented Dec 18, 2017

Could you create Migrate & API tickets referring to this deprecation?

dmethvin
dmethvin reviewed Dec 20, 2017
View reviewed changes
src/var/isFunction.js

return function isFunction( obj ) {

// Support: Chrome <=57, Firefox <=52
Copy link
Member

@dmethvin dmethvin Dec 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this function anymore? Currently we're at Chrome 62 and Firefox 57. Edit: Well hecky-darn nevermind, looks like Firefox ESR is still on 52 until the middle of next year. 😢

dmethvin
dmethvin approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems like we'll be able to remove isFunction next year but this will allow Migrate to start checking for external uses sooner.

@jbedard
Copy link
Contributor Author

jbedard commented Jan 5, 2018

Migrate: jquery/jquery-migrate#281
API: jquery/api.jquery.com#1074

@jbedard jbedard force-pushed the 3609 branch 2 times, most recently from 4657561 to 33ea9fd Compare January 8, 2018 17:30
@jbedard
Copy link
Contributor Author

jbedard commented Jan 14, 2018

Interesting that this one decreases size, unlike #3895. I guess the number of calls (that can now be renamed to a single character) is enough that it can only improve things, gziped or not.

   raw     gz Compared to master @ 6c38ebbd47c6b0fa654733819bd5ae36c1ac6c48
  -161     -9 dist/jquery.js
  -430    -19 dist/jquery.min.js

@jbedard jbedard merged commit 3d732cc into jquery:master Jan 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dmethvin dmethvin dmethvin approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate jQuery.isFunction

3 participants

@jbedard @mgol @dmethvin