Filter: Use direct filter in winnow #3910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
requested changes
Jan 9, 2018
src/traversing/findFilter.js
Outdated
| return jQuery.grep( elements, function( elem ) { | ||
| return ( indexOf.call( qualifier, elem ) > -1 ) !== not && elem.nodeType === 1; | ||
| } ); | ||
| // Filtered directly for both simple and complex elements |
Member
There was a problem hiding this comment.
typo: simple and complex selectors, not elements.
For both simple and complex selectors, use direct filter in winnow Closes jquerygh-3272
Member
|
Looks like the Travis CI build is testing due to travis-ci/travis-ci#8836. https://travis-ci.org/jquery/jquery/jobs/327104673 |
Contributor
Author
|
@Krinkle According to travis-ci/travis-ci#8836 (comment) we can either make |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both simple and complex selectors, use direct filter in winnow
Summary
As show here, the only-intersection implementation has an overall poor performance in all scenarios, and the direct implementation is equal or better than the branching implementation. Also it simplifies the code.
Hence, we can just use the direct filter implementation for both simple and complex selectors.
Checklist