Dimensions: avoid fetching boxSizing when setting width/height #4010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
reviewed
Mar 14, 2018
|
|
||
| // Only fetch boxSizing if required to avoid forcing a reflow (gh-3991) | ||
| isBorderBox = ( extra || scrollBoxSize ) && | ||
| jQuery.css( elem, "boxSizing", false, styles ) === "border-box", |
Member
There was a problem hiding this comment.
I like what the code is doing, but the reasons could be a little more clear. Suggestion to improve that (and reduce size a little bit as well):
diff --git i/src/css.js w/src/css.js
index fc000be..d7181f4 100644
--- i/src/css.js
+++ w/src/css.js
@@ -380,8 +380,9 @@ jQuery.each( [ "height", "width" ], function( i, dimension ) {
styles = getStyles( elem ),
scrollBoxSize = support.scrollboxSize() === styles.position,
- // Only fetch boxSizing if required to avoid forcing a reflow (gh-3991)
- isBorderBox = ( extra || scrollBoxSize ) &&
+ // To avoid forcing a reflow, only fetch boxSizing if we need it (gh-3991)
+ boxSizingNeeded = scrollBoxSize || extra,
+ isBorderBox = boxSizingNeeded &&
jQuery.css( elem, "boxSizing", false, styles ) === "border-box",
subtract = extra && boxModelAdjustment(
elem,
@@ -393,7 +394,7 @@ jQuery.each( [ "height", "width" ], function( i, dimension ) {
// Account for unreliable border-box dimensions by comparing offset* to computed and
// faking a content-box to get border and padding (gh-3699)
- if ( scrollBoxSize && isBorderBox ) {
+ if ( isBorderBox && scrollBoxSize ) {
subtract -= Math.ceil(
elem[ "offset" + dimension[ 0 ].toUpperCase() + dimension.slice( 1 ) ] -
parseFloat( styles[ dimension ] ) -
Contributor
Author
There was a problem hiding this comment.
That reduces size? Interesting, I thought an extra var would do the opposite...
I agree that is clearer 👍
Contributor
Author
There was a problem hiding this comment.
Adding the var and changing the comment:
+38 +11 dist/jquery.js
= = dist/jquery.min.js
Then changing the order in the if:
raw gz Compared to last run
= -1 dist/jquery.js
= = dist/jquery.min.js
So it didn't really change the size at all (but does make it more readable, so 👍)... @gibson042 is that the results you were getting?
Member
There was a problem hiding this comment.
I don't remember exactly, but this looks good to me.
- this avoids forcing a reflow in some cases Fixes jquery#3991
gibson042
approved these changes
Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3991
Adds a bit of size but I think it's worth it...