Issue 3964 outerWidth of svg yields NaNpx #4025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for boxModelAdjustment() to support svg element.
gibson042
requested changes
Apr 1, 2018
| // Assuming integer scroll gutter, subtract the rest and round down | ||
| delta += Math.max( 0, Math.ceil( | ||
| elem[ "offset" + dimension[ 0 ].toUpperCase() + dimension.slice( 1 ) ] - | ||
| ( elem[ "offset" + dimension[ 0 ].toUpperCase() + dimension.slice( 1 ) ] || 0 ) - |
Member
There was a problem hiding this comment.
I was anticipating the || 0 being farther out in this expression, and there may be problems from assuming that all SVG elements have no width or height. But that will all be resolved by unit tests covering SVG dimension getters, which this PR still needs.
Member
|
@kktam Do you think you'll be able to add the changes? |
Member
|
Closing in favor of #4096. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for boxModelAdjustment() to support svg element.
Summary
Checklist