🌐 AI搜索 & 代理 主页
Skip to content

Add possibly-unitless CSS grid properties #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We���ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 2 commits into from
Aug 29, 2018
Merged

Add possibly-unitless CSS grid properties #4028

mgol merged 2 commits into from
Aug 29, 2018

Conversation

@enbo
Copy link
Contributor

@enbo enbo commented Mar 29, 2018

Summary

Fixes #4007

Checklist

@enbo
Copy link
Contributor Author

enbo commented Mar 29, 2018

@mgol I'll start to look through the unit test you linked back in #4007:

jquery/test/unit/css.js

Lines 1120 to 1144 in 73d7e62

QUnit.test( "Do not append px (#9548, #12990, #2792)", function( assert ) {
assert.expect( 3 );
var $div = jQuery( "<div>" ).appendTo( "#qunit-fixture" );
$div.css( "fill-opacity", 1 );
assert.equal( $div.css( "fill-opacity" ), 1, "Do not append px to 'fill-opacity'" );
$div.css( "column-count", 1 );
if ( $div.css( "column-count" ) !== undefined ) {
assert.equal( $div.css( "column-count" ), 1, "Do not append px to 'column-count'" );
} else {
assert.ok( true, "No support for column-count CSS property" );
}
$div.css( "animation-iteration-count", 2 );
if ( $div.css( "animation-iteration-count" ) !== undefined ) {
// if $div.css( "animation-iteration-count" ) return "1",
// it actually return the default value of animation-iteration-count
assert.equal( $div.css( "animation-iteration-count" ), 2, "Do not append px to 'animation-iteration-count'" );
} else {
assert.ok( true, "No support for animation-iteration-count CSS property" );
}
} );

@timmywil
Copy link
Member

timmywil commented Apr 23, 2018

This needs tests, but can be merged in 3.4 once that happens.

mgol
mgol requested changes Apr 23, 2018
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as a WIP as it needs tests.

@mgol
Copy link
Member

mgol commented Jun 10, 2018

@enbo Hey, will you have time to work on the tests soon? If not, please let us know so that we can proceed ourselves here. Thanks!

@enbo
Copy link
Contributor Author

enbo commented Jun 10, 2018

@mgol I apologize for the radio silence! Lots of transition going on in life right now so I won't be able to complete the tests soon.

@mgol
Copy link
Member

mgol commented Jun 11, 2018 via email

@mgol mgol merged commit f997241 into jquery:master Aug 29, 2018
@mgol
Copy link
Member

mgol commented Aug 29, 2018

Landed, thanks!

mgol added a commit to mgol/jquery that referenced this pull request Aug 29, 2018
@mgol
Tests: Add tests for not auto-appending "px" to CSS Grid properties
af78b60 
Ref jquerygh-4007
Ref jquerygh-4028
@mgol mgol mentioned this pull request Aug 29, 2018
Merged
3 tasks
mgol added a commit to mgol/jquery that referenced this pull request Oct 3, 2018
@mgol
Tests: Add tests for not auto-appending "px" to CSS Grid properties
0dd32d3 
Ref jquerygh-4007
Ref jquerygh-4028
mgol added a commit that referenced this pull request Oct 3, 2018
@mgol
Tests: Add tests for not auto-appending "px" to CSS Grid properties
dae5f3c 
Ref gh-4007
Ref gh-4028
Closes gh-4165
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Oct 3, 2018
Merged
4 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Feb 25, 2019
@mgol mgol added this to the 3.4.0 milestone Jan 27, 2020
@mgol mgol added the CSS label Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mgol mgol mgol requested changes

Assignees

No one assigned

Labels

CSS

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

Cannot set property "grid-column-start" using .css()

3 participants

@enbo @timmywil @mgol