Fix retrieving children of <object> using contents()
#4385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e41e5b8 to
1cc978f
Compare
mgol
approved these changes
May 4, 2019
Member
mgol
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
Member
|
Note to self: remember to cherry-pick this to |
gibson042
approved these changes
May 4, 2019
timmywil
approved these changes
May 6, 2019
Member
timmywil
left a comment
There was a problem hiding this comment.
This looks good and has enough reviews.
Member
|
I merged it and the newly added test fails in IE: http://swarm.jquery.org/result/3328701 |
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 6, 2019
The original fix didn't account for the fact that in IE `<object>` elements with no `data` attribute have an object `contentDocument`. The fix leverages the fact that this special object has a null prototype. Ref jquerygh-4384 Ref jquerygh-4385
2 tasks
Member
|
PR with a fix for IE 11: #4390 |
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 6, 2019
The original fix didn't account for the fact that in IE `<object>` elements with no `data` attribute have an object `contentDocument`. The fix leverages the fact that this special object has a null prototype. Ref jquerygh-4384 Ref jquerygh-4385
4 tasks
patocallaghan
added a commit
to intercom/jquery
that referenced
this pull request
May 7, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4384
Summary
Since 0ba8e38, using
contents()to get the children of an<object>is not working.Taking this example HTML
I'd expect the following to happen
But what actually happens is:
Changing the conditional to
elem.contentDocument != nullhandles this case and the function returns the correct children.Checklist