Build: Make dev mode work in Karma again, serve source files from disk #4574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ff0f36 to
7630e9f
Compare
timmywil
approved these changes
Jan 7, 2020
PR jquerygh-4550 added support for running ES modules & AMD tests via Karma. This required reading the `esmodules` & `amd` props from both `QUnit.config` & `QUnit.urlParams`. By picking these two properties manually, the `dev` one stopped being respected while ones handled directly by QUnit were fine (like `hidepassed`). Instead of maintaining the full list of options, the code now iterates over QUnit URL config and handles the fallbacks in a more generic way. Apart from that, all jQuery source & test files are now read directly from disk instead of being cached by Karma so that one can run `grunt karma:chrome-debug` & work on a fix without restarting that Karma run after each change. A similar effect could have been achieved by setting `autoWatch` to `true` but then the main Karma page runs tests in an iframe by default when `grunt karma:chrome-debug` is run instead of relying on the current debug flow. Ref jquerygh-4550
7630e9f to
9bb5b2d
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 8, 2020
Also, run such a suite in CI to make sure modules are working as expected when used directly. (partially cherry picked from 341c6d1) Ref jquerygh-4550 Ref jquerygh-4574
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 8, 2020
Also, run such a suite in CI to make sure modules are working as expected when used directly. (partially cherry picked from 341c6d1) (partially cherry picked from 437f389) Ref jquerygh-4550 Ref jquerygh-4574
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 8, 2020
Also, run such a suite in CI to make sure modules are working as expected when used directly. (partially cherry picked from 341c6d1) (partially cherry picked from 437f389) Ref jquerygh-4550 Ref jquerygh-4574
gaohuia
pushed a commit
to gaohuia/jquery
that referenced
this pull request
Jan 9, 2020
PR jquerygh-4550 added support for running ES modules & AMD tests via Karma. This required reading the `esmodules` & `amd` props from both `QUnit.config` & `QUnit.urlParams`. By picking these two properties manually, the `dev` one stopped being respected while ones handled directly by QUnit were fine (like `hidepassed`). Instead of maintaining the full list of options, the code now iterates over QUnit URL config and handles the fallbacks in a more generic way. Apart from that, all jQuery source & test files are now read directly from disk instead of being cached by Karma so that one can run `grunt karma:chrome-debug` & work on a fix without restarting that Karma run after each change. A similar effect could have been achieved by setting `autoWatch` to `true` but then the main Karma page runs tests in an iframe by default when `grunt karma:chrome-debug` is run instead of relying on the current debug flow. Closes jquerygh-4574 Ref jquerygh-4550
2 tasks
mgol
added a commit
that referenced
this pull request
Jan 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR gh-4550 added support for running ES modules & AMD tests via Karma. This
required reading the
esmodules&amdprops from bothQUnit.config&QUnit.urlParams. By picking these two properties manually, thedevonestopped being respected while ones handled directly by QUnit were fine (like
hidepassed). Instead of maintaining the full list of options, the code nowiterates over QUnit URL config and handles the fallbacks in a more generic way.
Apart from that, all jQuery source & test files are now read directly from disk
instead of being cached by Karma so that one can run
grunt karma:chrome-debug& work on a fix without restarting that Karma run after each change. A similar
effect could have been achieved by setting
autoWatchtotruebut then themain Karma page runs tests in an iframe by default when
grunt karma:chrome-debugis run instead of relying on the current debug flow.Ref gh-4550
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com