🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jan 21, 2020

Summary

This PR fixes unit tests for the following builds:

  1. The no-deprecated build: custom:-deprecated
  2. The current slim build: custom:-ajax,-effects
  3. The 4.0 (Core: Exclude callbacks & deferred modules in the slim build as well #4553) slim build: custom:-ajax,-callbacks,-deferred,-effects

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref gh-4577
Ref gh-4596

Checklist

This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref jquerygh-4577
Ref jquerygh-4596
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@mgol mgol removed the Needs review label Jan 27, 2020
@mgol mgol merged commit d525ae3 into jquery:3.x-stable Jan 27, 2020
@mgol mgol deleted the 3.x-custom-build-fixes branch January 27, 2020 17:54
@mgol mgol added this to the 3.5.0 milestone Jan 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants