Event: remove jQuery.event.global #4602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery.event.global has been write-only in the jQuery source for the past few years; reading from it was removed in c2d6847 when fixing the trac-12989 bug.
Member
Author
|
-11 bytes |
dmethvin
approved these changes
Feb 5, 2020
Member
dmethvin
left a comment
There was a problem hiding this comment.
LGTM. The idea was that we could skip some steps if we knew we had never attached a handler for a specific event name, but as I recall it had some gotcha so that's why the tracking was removed. I don't see any reason to try to fill this in Migrate either.
timmywil
approved these changes
Feb 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jQuery.event.global has been write-only in the jQuery source for the past few
years; reading from it was removed in c2d6847
when fixing the trac-12989 bug.
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com