Build: Add Christian Oliff to .mailmap & AUTHORS.txt #4613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
Feb 24, 2020
| Chris Rebert <github@rebertia.com> | ||
| Chris Rebert <github@rebertia.com> <code@rebertia.com> | ||
| Christian Oliff <christianoliff@pm.me> | ||
| Christian Oliff <christianoliff@pm.me> <christianoliff@yahoo.com> |
Member
Author
There was a problem hiding this comment.
@coliff Which email do you prefer? Each of your two commits have been done under a different one; these entries will normalize it.
I made this PR with the assumption you prefer christianoliff@pm.me but let me know if you prefer the other one & I'll reverse the PR.
Contributor
There was a problem hiding this comment.
christianoliff@pm.me would be perfect. thanks again!
timmywil
approved these changes
Feb 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Christian Oliff to
.mailmap&AUTHORS.txt.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com