🌐 AI搜索 & 代理 主页
Skip to content

Build: Correct code indentations based on jQuery Style Guide #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
May 5, 2020
Merged

Build: Correct code indentations based on jQuery Style Guide #4672

mgol merged 1 commit into from
May 5, 2020

Conversation

@wonseop
Copy link
Contributor

@wonseop wonseop commented Apr 17, 2020 •
edited
Loading

Summary

Checklist

@mgol
Copy link
Member

mgol commented Apr 17, 2020

Thanks for the PR!

I'm wondering if we shouldn't just enable the indent option, at least in src/.eslintrc.json. I'm sure there are some violations but I've heard that rule has improved a lot recently so maybe it'd be feasible for us to use it. That way we won't need to apply such small indentation fixes but we'll be sure it's fine all the time.

Docs for the indent rule: https://eslint.org/docs/rules/indent.

Would you like to have a look at that?

@wonseop wonseop force-pushed the idiom branch 2 times, most recently from 7b84c3e to dfed21e Compare April 23, 2020 11:11
mgol
mgol requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments. Overall, this looks great! I was afraid we'd need more source changes.

@wonseop wonseop changed the title Correct code indentation according to Core Style Guide Correct code indentation based on Core Style Guide Apr 24, 2020
@wonseop wonseop force-pushed the idiom branch 2 times, most recently from 0e2964d to 8bcc817 Compare April 24, 2020 07:33
mgol
mgol reviewed Apr 24, 2020
View reviewed changes
mgol
mgol requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch over latest master. There have been some changes to the ESLint config recently so I'd like to be sure it passes the lint.

@wonseop
Correct code indentations
76fb3ef 
1. Correct code indentations based on Core Style Guide.
   (https://contribute.jquery.org/style-guide/js/#spacing)

2. Add rules to "src/.eslintrc.json" to enable "enforcing consistent indentation",
   with minimal changes to the current code.
@wonseop wonseop changed the title Correct code indentation based on Core Style Guide Build: Correct code indentations based on Core Style Guide. Apr 27, 2020
@wonseop wonseop requested a review from mgol April 27, 2020 01:53
mgol
mgol approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@mgol mgol added Build Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Apr 27, 2020
@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Apr 28, 2020
@mgol
Copy link
Member

mgol commented Apr 29, 2020

@timmywil We didn't discuss it yet, I wanted a final team approval so let me add the label back.

@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Apr 29, 2020
timmywil
timmywil approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels May 4, 2020
@mgol mgol added this to the 4.0.0 milestone May 4, 2020
@mgol mgol changed the title Build: Correct code indentations based on Core Style Guide. Build: Correct code indentations based on jQuery Style Guide May 5, 2020
@mgol mgol merged commit 3d62d57 into jquery:master May 5, 2020
mgol pushed a commit to mgol/jquery that referenced this pull request May 5, 2020
@wonseop @mgol
Build: Correct code indentations based on jQuery Style Guide
9b8cadc 
1. Correct code indentations based on jQuery Style Guide
   (contribute.jquery.org/style-guide/js/#spacing).
2. Add rules to "src/.eslintrc.json" to enable "enforcing consistent
   indentation", with minimal changes to the current code.

Closes jquerygh-4672

(cherry picked from 3d62d57)
@mgol mgol removed this from the 4.0.0 milestone May 5, 2020
@mgol mgol added this to the 3.6.0 milestone May 5, 2020
@mgol
Copy link
Member

mgol commented May 5, 2020

Landed, thanks, @wonseop!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

@mgol mgol mgol approved these changes

Assignees

No one assigned

Labels

Build

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wonseop @mgol @timmywil