🌐 AI搜索 & 代理 主页
Skip to content

Tests: Skip ETag AJAX tests on TestSwarm #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Dec 1, 2021
Merged

Tests: Skip ETag AJAX tests on TestSwarm #4974

mgol merged 1 commit into from
Dec 1, 2021

Conversation

@mgol
Copy link
Member

@mgol mgol commented Nov 18, 2021

Summary

TestSwarm is now proxied via Cloudflare which cuts out headers relevant for
ETag tests, failing them. We're still running those tests in Karma on Chrome
& Firefox (including Firefox ESR).

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

@mgol mgol added this to the 3.6.1 milestone Nov 18, 2021
@mgol mgol self-assigned this Nov 18, 2021
@brianwarner
Copy link

brianwarner commented Nov 18, 2021

/easycla

timmywil
timmywil approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol force-pushed the ajax-swarm-skip-etag branch from caa5f01 to 19bf022 Compare November 18, 2021 23:50
@mgol
Tests: Skip ETag AJAX tests on TestSwarm
3c7dcb0 
TestSwarm is now proxied via Cloudflare which cuts out headers relevant for
ETag tests, failing them. We're still running those tests in Karma on Chrome
& Firefox (including Firefox ESR).
@mgol mgol force-pushed the ajax-swarm-skip-etag branch from 19bf022 to 3c7dcb0 Compare November 30, 2021 23:09
@mgol mgol removed the Needs review label Dec 1, 2021
@mgol mgol merged commit 00c060d into jquery:main Dec 1, 2021
@mgol mgol deleted the ajax-swarm-skip-etag branch December 1, 2021 11:46
mgol added a commit that referenced this pull request Dec 1, 2021
@mgol
Tests: Skip ETag AJAX tests on TestSwarm
81fa1e2 
TestSwarm is now proxied via Cloudflare which cuts out headers relevant for
ETag tests, failing them. We're still running those tests in Karma on Chrome
& Firefox (including Firefox ESR).

Closes gh-4974

(cherry picked from commit 00c060d)
@mgol
Copy link
Member Author

mgol commented Dec 1, 2021

Landed on main in 00c060d & on 3.x-stable in 81fa1e2.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

Tests

Milestone

3.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mgol @brianwarner @timmywil