🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jan 4, 2022

Summary

PR gh-4993 changed a few too many issue references to trac-NUMBER ones. This
change fixes them. It also fixes a typo in one Trac issue number in selector
tests.

Ref gh-4993

For this, I manually went through all trac-NUMBER references for numbers below 5000 (I used regex /trac-(?:\d{1,3}|[1-4]\d{3})\b/).

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

PR jquerygh-4993 changed a few too many issue references to `trac-NUMBER` ones. This
change fixes them. It also fixes a typo in one Trac issue number in selector
tests.

Ref jquerygh-4993
@mgol mgol added this to the 4.0.0 milestone Jan 4, 2022
@mgol mgol requested a review from timmywil January 4, 2022 23:53
@mgol mgol self-assigned this Jan 4, 2022
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going back and checking these.

@mgol mgol removed the Needs review label Jan 12, 2022
@mgol mgol merged commit eb9ceb2 into jquery:main Jan 12, 2022
@mgol mgol deleted the trac-links-followup branch January 12, 2022 22:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants