CSS: Don’t trim whitespace of undefined custom property #5106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1d8ec8d to
df326d9
Compare
Member
|
Thanks for the PR with a test! We’ll discuss what approach we want to take here and we’ll get back to you. |
mgol
requested changes
Sep 12, 2022
Member
mgol
left a comment
There was a problem hiding this comment.
Just one comment, otherwise it looks good to me. Thanks!
df326d9 to
92540d3
Compare
92540d3 to
4fb461c
Compare
Contributor
Author
|
This is a cross-browser difference with I’ve changed the test to |
Fixes jquerygh-5105 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
4fb461c to
ee6718a
Compare
Contributor
Author
|
Rebased. |
andersk
added a commit
to andersk/jquery
that referenced
this pull request
Sep 19, 2022
Fixes jquerygh-5105 Closes jquerygh-5106 Signed-off-by: Anders Kaseorg <andersk@mit.edu> (cherry picked from commit ed306c0)
3 tasks
Contributor
Author
|
Backported to |
Member
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 21, 2022
The spec requires that CSS variable values are trimmed. In browsers that do this - mainly, Safari, but also Firefox if the value only has leading whitespace - we currently return `undefined`; in other browsers, we return an empty string as the logic to fall back to `undefined` happens before trimming. This commit adds another explicit callback to `undefined`. Also, more explicit comments about behaviors we need to work around in various browsers have been added. Ref jquerygh-5106
2 tasks
Member
I submitted #5120 to handle this case. |
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 21, 2022
The spec requires that CSS variable values are trimmed. In browsers that do this - mainly, Safari, but also Firefox if the value only has leading whitespace - we currently return `undefined`; in other browsers, we return an empty string as the logic to fall back to `undefined` happens before trimming. This commit adds another explicit callback to `undefined` to have it consistent across browsers. Also, more explicit comments about behaviors we need to work around in various browsers have been added. Ref jquerygh-5106
mgol
added a commit
that referenced
this pull request
Oct 3, 2022
The spec requires that CSS variable values are trimmed. In browsers that do this - mainly, Safari, but also Firefox if the value only has leading whitespace - we currently return undefined; in other browsers, we return an empty string as the logic to fall back to undefined happens before trimming. This commit adds another explicit callback to `undefined` to have it consistent across browsers. Also, more explicit comments about behaviors we need to work around in various browsers have been added. Closes gh-5120 Ref gh-5106
mgol
added a commit
that referenced
this pull request
Oct 3, 2022
The spec requires that CSS variable values are trimmed. In browsers that do this - mainly, Safari, but also Firefox if the value only has leading whitespace - we currently return undefined; in other browsers, we return an empty string as the logic to fall back to undefined happens before trimming. This commit adds another explicit callback to `undefined` to have it consistent across browsers. Also, more explicit comments about behaviors we need to work around in various browsers have been added. Closes gh-5120 Ref gh-5106 (cherry picked from commit 7eb0019)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-5105
Checklist