🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Oct 17, 2022

Summary

Firefox 106 adjusted to the spec mandating that CSS.supports("selector(...)") uses non-forgiving parsing which makes it pass the relevant support test.

Note: I only check for Fx 102 in the test as it's just a support test and Fx 102 is an ESR version; the other tested ones will soon go out of support. This means the test will only start passing tomorrow once Firefox 106 gets released.

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

@mgol mgol added Needs review Tests Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Oct 17, 2022
@mgol mgol added this to the 3.6.2 milestone Oct 17, 2022
@mgol mgol self-assigned this Oct 17, 2022
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmywil timmywil removed Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Oct 17, 2022
@mgol
Copy link
Member Author

mgol commented Oct 18, 2022

Firefox 106 is out but we still need to wait until the Ubuntu firefox package gets an update: https://packages.ubuntu.com/focal/firefox. Hopefully, it'll happen soon.

@mgol
Copy link
Member Author

mgol commented Oct 19, 2022

Ah, this is 4.0-only as on the 3.x-stable branch we use Sizzle and the result of this support check is not checked. I just need to backport that to my Sizzle inlining PR. Updating the milestone...

@mgol mgol modified the milestones: 3.6.2, 4.0.0 Oct 19, 2022
@mgol mgol force-pushed the fx-support branch 2 times, most recently from 8d89666 to 976b3a9 Compare November 1, 2022 19:54
Firefox 106 adjusted to the spec mandating that `CSS.supports("selector(...)")`
uses non-forgiving parsing which makes it pass the relevant support test.
@mgol mgol merged commit 716130e into jquery:main Nov 24, 2022
@mgol mgol deleted the fx-support branch November 24, 2022 23:54
mgol added a commit to mgol/jquery that referenced this pull request Nov 25, 2022
Firefox 106 adjusted to the spec mandating that `CSS.supports("selector(...)")`
uses non-forgiving parsing which makes it pass the relevant support test.

Closes jquerygh-5141

(cherry picked from commit 716130e)
mgol added a commit to mgol/jquery that referenced this pull request Dec 1, 2022
Firefox 106 adjusted to the spec mandating that `CSS.supports("selector(...)")`
uses non-forgiving parsing which makes it pass the relevant support test.

Closes jquerygh-5141

(cherry picked from commit 716130e)
mgol added a commit to mgol/jquery that referenced this pull request Dec 13, 2022
Firefox 106 adjusted to the spec mandating that `CSS.supports("selector(...)")`
uses non-forgiving parsing which makes it pass the relevant support test.

Closes jquerygh-5141

(cherry picked from commit 716130e)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants