Selector:Manipulation: Fix DOM manip within template contents #5159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
approved these changes
Nov 15, 2022
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 16, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490. This PR pulls the new Sizzle version into jQuery's `3.x-stable` branch and backports one test from jquerygh-5158. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158
1f6c175 to
ffdd09b
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 16, 2022
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158
ffdd09b to
5e40c14
Compare
The `<template/>` element `contents` property is a document fragment that may have a `null` `documentElement`. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now. The crash used to happen in `jQuery.contains` which is an alias for `Sizzle.contains` in jQuery 3.x. The Sizzle fix is at jquery/sizzle#490, released in Sizzle `2.3.8`. This version of Sizzle is included in the parent commit. A fix similar to the one from jquerygh-5158 has also been applied here to the `selector-native` version. Fixes jquerygh-5147 Closes jquerygh-5159 Ref jquery/sizzle#490 Ref jquerygh-5158
5e40c14 to
bc23c1c
Compare
Member
Author
|
@timmywil I also had to apply a fix to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
<template/>elementcontentsproperty is a document fragment that may have anulldocumentElement. In Safari 16 this happens in more cases due to recent spec changes - in particular, even if that document fragment is explicitly adopted into an outer document. We're testing both of those cases now.The crash used to happen in
jQuery.containswhich is an alias forSizzle.containsin jQuery 3.x.The Sizzle fix is at jquery/sizzle#490. This PR pulls the new Sizzle version into jQuery's
3.x-stablebranch and backports one test from gh-5158.Fixes gh-5147
Ref jquery/sizzle/pull/490
Ref gh-5158
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com