🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

Summary

Fixes typos found by codespell.

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 24, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DimitriPapadopoulos / name: Dimitri Papadopoulos Orfanos (94413ac)

@mgol
Copy link
Member

mgol commented Jun 27, 2023

Thanks for the PR. I see some other codespell errors reported, e.g. in traversing tests. Can you fix them all in one go?

@DimitriPapadopoulos
Copy link
Contributor Author

You mean datas and failer?

I had kept datas as a neologism which means data_list or something like that, as in other projects it is often used as for ( data in datas ) {, but it's easy to change here.

And failer is often used as a neologism for a test/condition that fails.

@mgol
Copy link
Member

mgol commented Jun 27, 2023

failer seems fine, traversing has childs, though, which seems wrong. Here's what I got (obviously, many of these results are wrong):

$ codespell --skip="AUTHORS.txt,./amd,./dist,./external,./node_modules,package-lock.json,./test/data/jquery-1.9.1.js"
./package.json:113: clos ==> close
./test/unit/selector.js:200: visble ==> visible
./test/unit/event.js:652: zar ==> czar
./test/unit/event.js:657: zar ==> czar
./test/unit/attributes.js:1178: te ==> the, be, we, to
./test/unit/attributes.js:1186: te ==> the, be, we, to
./test/unit/attributes.js:1187: te ==> the, be, we, to
./test/unit/attributes.js:1193: te ==> the, be, we, to
./test/unit/attributes.js:1194: te ==> the, be, we, to
./test/unit/attributes.js:1286: fo ==> of, for, to, do, go
./test/unit/attributes.js:1287: fo ==> of, for, to, do, go
./test/unit/attributes.js:1754: te ==> the, be, we, to
./test/unit/attributes.js:1755: te ==> the, be, we, to
./test/unit/traversing.js:193: childs ==> children, child's
./test/unit/traversing.js:194: childs ==> children, child's
./test/unit/ajax.js:2714: overrided ==> overrode, overridden
./test/unit/data.js:599: datas ==> data
./test/unit/data.js:638: datas ==> data
./test/unit/data.js:659: datas ==> data
./test/unit/data.js:731: datas ==> data
./test/unit/data.js:742: datas ==> data
./test/unit/data.js:760: datas ==> data
./test/unit/data.js:779: datas ==> data
./test/unit/data.js:793: datas ==> data
./test/unit/deferred.js:697: failer ==> failure
./test/unit/deferred.js:709: failer ==> failure
./test/unit/deferred.js:709: failer ==> failure
./test/unit/css.js:1412: convertable ==> convertible
./test/unit/css.js:1417: convertable ==> convertible
./test/unit/css.js:1418: convertable ==> convertible
./build/tasks/build.js:63: optIn ==> option
./build/tasks/build.js:278: optIn ==> option
./src/manipulation/domManip.js:78: Reenable ==> Re-enable

@DimitriPapadopoulos
Copy link
Contributor Author

Indeed. I was used to seeing childs used as a list of child items, the same way datas is used as a list of data items. But here it's a genuine misspelling in an error message.

Fixed.

@DimitriPapadopoulos
Copy link
Contributor Author

And yes, the rest are false positives, except datas and failer which are not real words but make sense in this context.

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgol mgol added Docs and removed Needs info labels Jun 27, 2023
@mgol mgol added this to the 3.7.1 milestone Jun 27, 2023
@mgol mgol changed the title Fix typos found by codespell Docs: Fix typos found by codespell Jun 27, 2023
@mgol mgol merged commit 620870a into jquery:main Jun 27, 2023
mgol pushed a commit that referenced this pull request Jun 27, 2023
Closes gh-5165

(cherry picked from commit 620870a)
@mgol
Copy link
Member

mgol commented Jun 27, 2023

Landed on main in 620870a & in 3.x-stable in 4a29888.

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch June 28, 2023 07:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants