Selector: Implement the uniqueSort chainable method
#5168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fa3e39 to
59fccb8
Compare
Some APIs, like `.prevAll()`, return elements in the reversed order, causing confusing behavior when used with wrapping methods (see jquerygh-5149 for more info) To provide an easy workaround, this commit implements a chainable `uniqueSort` method on jQuery objects, an equivalent of `jQuery.uniqueSort`. Fixes jquerygh-5166
59fccb8 to
f43b660
Compare
gibson042
approved these changes
Nov 27, 2022
timmywil
approved these changes
Nov 28, 2022
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 14, 2022
Some APIs, like `.prevAll()`, return elements in the reversed order, causing confusing behavior when used with wrapping methods (see jquerygh-5149 for more info) To provide an easy workaround, this commit implements a chainable `uniqueSort` method on jQuery objects, an equivalent of `jQuery.uniqueSort`. Fixes jquerygh-5166 Closes jquerygh-5168 (cherry picked from commit 5266f23)
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some APIs, like
.prevAll(), return elements in the reversed order, causing confusing behavior when used with wrapping methods (see gh-5149 for more info)To provide an easy workaround, this commit implements a chainable
uniqueSortmethod on jQuery objects, an equivalent of
jQuery.uniqueSort.Fixes gh-5166
+12 bytes
Checklist