🌐 AI搜索 & 代理 主页
Skip to content

Tests: Test AJAX deprecated event aliases properly #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We��ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Mar 15, 2023
Merged

Tests: Test AJAX deprecated event aliases properly #5195

mgol merged 1 commit into from
Mar 15, 2023

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jan 15, 2023 •
edited
Loading

Summary

PR gh-5046 erroneously changed AJAX deprecated event alias usage in deprecated tests to .on() calls. This change reverses this mistake.

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

@mgol
Tests: Test AJAX deprecated event aliases properly
25b55bd 
PR jquerygh-5046 erroneously changed AJAX deprecated event alias
usage in deprecated tests to `.on()` calls. This change
reverses this mistake.
@mgol mgol added this to the 3.7.0 milestone Jan 15, 2023
@mgol mgol self-assigned this Jan 15, 2023
@mgol mgol requested a review from timmywil February 1, 2023 12:50
@mgol mgol removed the Needs review label Mar 15, 2023
@mgol mgol merged commit cff2899 into jquery:main Mar 15, 2023
@mgol mgol deleted the ajax-aliases-deprecated-tests branch March 15, 2023 10:44
mgol added a commit that referenced this pull request Mar 15, 2023
@mgol
Tests: Test AJAX deprecated event aliases properly
1813921 
PR gh-5046 erroneously changed AJAX deprecated event alias
usage in deprecated tests to `.on()` calls. This change
reverses this mistake.

Closes gh-5195
Ref gh-5046

(cherry picked from commit cff2899)
@mgol
Copy link
Member Author

mgol commented Mar 15, 2023

Landed on main in cff2899 & on 3.x-stable in 1813921.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dmethvin dmethvin dmethvin approved these changes

@timmywil timmywil Awaiting requested review from timmywil

Assignees

@mgol mgol

Labels

Tests

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @dmethvin