Ajax: Don't treat array data as binary #5203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
timmywil
approved these changes
Mar 20, 2023
PR jquerygh-5197 started treating all non-string non-plain-object `data` values as binary. However, `jQuery.ajax` also supports arrays as values of `data`. This change makes regular arrays no longer be considered binary data. Surprisingly, we had no tests for array `data` values; otherwise, we'd detect the issue earlier. This change also adds a few such missing tests. Ref jquerygh-5197
517a1e1 to
c6077e5
Compare
Member
|
Please add these same tests to 3.x |
mgol
added a commit
that referenced
this pull request
Mar 20, 2023
PR gh-5197 started treating all non-string non-plain-object `data` values as binary. However, `jQuery.ajax` also supports arrays as values of `data`. This change didn't land on `3.x-stable`; however... Surprisingly, we had no tests for array `data` values. This change backports a few such missing tests added in gh-5203. Ref gh-5197 Ref gh-5203
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR gh-5197 started treating all non-string non-plain-object
datavalues as binary. However,jQuery.ajaxalso supports arrays as values ofdata. This change makes regular arrays no longer be considered binary data.Surprisingly, we had no tests for array
datavalues; otherwise, we'd detect the issue earlier. This change also adds a few such missing tests.Ref gh-5197
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com