Deferred: Rename getStackHook to getErrorHook
#5211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Feb 15, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `3.7.0` version; PR jquerygh-5211 implements the `4.0.0` one. Fixes jquerygh-5201 Closes jquerygh-5212 Ref jquerygh-5211
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Feb 15, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `4.0.0` version; PR jquerygh-5212 implements the `3.7.0` one. Fixes jquerygh-5201 Closes jquerygh-5211 Ref jquerygh-5212
Member
Author
|
A few JS Bins to test what gets passed to the hook, justifying the name change:
|
Member
Author
|
PR to @dmethvin's |
This was referenced Feb 15, 2023
dmethvin
approved these changes
Feb 24, 2023
timmywil
approved these changes
Mar 13, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `4.0.0` version; PR jquerygh-5212 implements the `3.7.0` one. Fixes jquerygh-5201 Closes jquerygh-5211 Ref jquerygh-5212
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Mar 14, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `3.7.0` version; PR jquerygh-5211 implements the `4.0.0` one. Fixes jquerygh-5201 Closes jquerygh-5212 Ref jquerygh-5211
mgol
added a commit
that referenced
this pull request
Mar 14, 2023
Rename `jQuery.Deferred.getStackHook` to `jQuery.Deferred.getErrorHook` to indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not. In jQuery `3.7.0`, we'll keep both names, marking the old one as deprecated. In jQuery `4.0.0` we'll just keep the new one. This change implements the `3.7.0` version; PR gh-5211 implements the `4.0.0` one. Fixes gh-5201 Closes gh-5212 Ref gh-5211
This was referenced Oct 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
jQuery.Deferred.getStackHooktojQuery.Deferred.getErrorHookto indicate passing an error instance is usually a better choice - it works with source maps while a raw stack generally does not.In jQuery
3.7.0, we'll keep both names, marking the old one as deprecated. In jQuery4.0.0we'll just keep the new one. This change implements the4.0.0version; PR gh-5212 implements the3.7.0one.Fixes gh-5201
Ref gh-5212
Checklist