Release: add support for md5 sums in windows #5218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f39dcc to
ab1ae19
Compare
mgol
approved these changes
Mar 7, 2023
Member
mgol
left a comment
There was a problem hiding this comment.
LGTM with one style suggestion. I assume this is to be cherry-picked to main & 3.x-stable as well.
Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Mar 8, 2023
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Mar 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I wanted to see if the release could be run on Windows. To my surprise, the md5 hash was the only thing that didn't work.
This checks the OS and switches up the command used for the md5 sums and formats it the same way as default mac/linux.
Checklist