CSS: Make offsetHeight( true ), etc. include negative margins
#5234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in jquerygh-3656 as the added logic to include scroll gutters in `.innerWidth()` / `.innerHeight()` didn't take negative margins into account. This broke handling of negative margins in `.offsetHeight( true )` and `.offsetWidth( true )`. To fix it, calculate margin delta separately and only add it after the scroll gutter adjustment logic. Fixes jquerygh-3982 Ref jquerygh-3656
timmywil
approved these changes
Apr 3, 2023
Member
Author
|
@gibson042 I'd like to start asking some projects to test against |
mgol
added a commit
that referenced
this pull request
Apr 4, 2023
This regressed in gh-3656 as the added logic to include scroll gutters in `.innerWidth()` / `.innerHeight()` didn't take negative margins into account. This broke handling of negative margins in `.offsetHeight( true )` and `.offsetWidth( true )`. To fix it, calculate margin delta separately and only add it after the scroll gutter adjustment logic. Fixes gh-3982 Closes gh-5234 Ref gh-3656 (cherry picked from commit bce13b7)
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This regressed in gh-3656 as the added logic to include scroll gutters in
.innerWidth()/.innerHeight()didn't take negative margins into account. This broke handling of negative margins in.offsetHeight( true )and.offsetWidth( true ). To fix it, calculate margin delta separately and only add it after the scroll gutter adjustment logic.Fixes gh-3982
Ref gh-3656
+4 bytes
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com