🌐 AI搜索 & 代理 主页
Skip to content

Deprecated: Define .hover() using non-deprecated methods #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
May 22, 2023
Merged

Deprecated: Define .hover() using non-deprecated methods #5251

mgol merged 1 commit into from
May 22, 2023

Conversation

@mgol
Copy link
Member

@mgol mgol commented May 15, 2023

Summary

Make the deprecated .hover() method not rely on other deprecated methods: .mouseenter() & .mouseleave(). Use .on() instead.

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

@mgol
Deprecated: Define .hover() using non-deprecated methods
bd6ee1f 
Make the deprecated `.hover()` method not rely on other deprecated
methods: `.mouseenter()` & `.mouseleave()`. Use `.on()` instead.
@mgol mgol self-assigned this May 15, 2023
@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label May 15, 2023
timmywil
timmywil approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmywil timmywil removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels May 22, 2023
@mgol mgol added this to the 3.7.1 milestone May 22, 2023
@mgol mgol merged commit fd6ffc5 into jquery:main May 22, 2023
@mgol mgol deleted the hover-nested-deprecation branch May 22, 2023 16:23
mgol added a commit that referenced this pull request May 22, 2023
@mgol
Deprecated: Define .hover() using non-deprecated methods
7287894 
Make the deprecated `.hover()` method not rely on other deprecated
methods: `.mouseenter()` & `.mouseleave()`. Use `.on()` instead.

Closes gh-5251

(cherry picked from commit fd6ffc5)
@mgol
Copy link
Member Author

mgol commented May 22, 2023

Landed in fd6ffc5 on main & in 7287894 on 3.x-stable.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dmethvin dmethvin dmethvin approved these changes

@timmywil timmywil timmywil approved these changes

@gibson042 gibson042 gibson042 approved these changes

Assignees

@mgol mgol

Labels

Deprecated

Milestone

3.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mgol @dmethvin @timmywil @gibson042