Selector: Re-expose jQuery.find.{tokenize,select,compile,setDocument} #5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 1, 2023
`Sizzle.tokenize` is an internal Sizzle API, but exposed. As a result, it has historically been available in jQuery via `jQuery.find.tokenize`. That got dropped during Sizzle removal; this change restores the API. In addition to that, Sizzle tests have been backported for the following APIs: * `jQuery.find.matchesSelector` * `jQuery.find.matches` * `jQuery.find.compile` * `jQuery.find.select` A new test was also added for `jQuery.find.tokenize` - even Sizzle was missing one. Fixes jquerygh-5259 Ref jquerygh-5263 Ref jquery/sizzle#242 Ref jquerygh-5113 Ref jquerygh-4395 Ref jquerygh-4406
3 tasks
`Sizzle.tokenize` is an internal Sizzle API, but exposed. As a result, it has historically been available in jQuery via `jQuery.find.tokenize`. That got dropped during Sizzle removal; this change restores the API. Some other APIs so far only exposed on the `3.x` line are also added back: * `jQuery.find.select` * `jQuery.find.compile` * `jQuery.find.setDocument` In addition to that, Sizzle tests have been backported for the following APIs: * `jQuery.find.matchesSelector` * `jQuery.find.matches` * `jQuery.find.compile` * `jQuery.find.select` A new test was also added for `jQuery.find.tokenize` - even Sizzle was missing one. Fixes jquerygh-5259 Ref jquerygh-5260 Ref jquery/sizzle#242 Ref jquerygh-5113 Ref jquerygh-4395 Ref jquerygh-4406
timmywil
approved these changes
Jun 1, 2023
mgol
added a commit
that referenced
this pull request
Jun 12, 2023
`Sizzle.tokenize` is an internal Sizzle API, but exposed. As a result, it has historically been available in jQuery via `jQuery.find.tokenize`. That got dropped during Sizzle removal; this change restores the API. In addition to that, Sizzle tests have been backported for the following APIs: * `jQuery.find.matchesSelector` * `jQuery.find.matches` * `jQuery.find.compile` * `jQuery.find.select` A new test was also added for `jQuery.find.tokenize` - even Sizzle was missing one. Fixes gh-5259 Closes gh-5260 Ref gh-5263 Ref jquery/sizzle#242 Ref gh-5113 Ref gh-4395 Ref gh-4406
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sizzle.tokenizeis an internal Sizzle API, but exposed. As a result,it has historically been available in jQuery via
jQuery.find.tokenize.That got dropped during Sizzle removal; this change restores the API.
Some other APIs so far only exposed on the
3.xline are also addedback:
jQuery.find.selectjQuery.find.compilejQuery.find.setDocumentIn addition to that, Sizzle tests have been backported for the following
APIs:
jQuery.find.matchesSelectorjQuery.find.matchesjQuery.find.compilejQuery.find.selectA new test was also added for
jQuery.find.tokenize- even Sizzle wasmissing one.
Fixes gh-5259
Ref gh-5260
Ref jquery/sizzle#242
Ref gh-5113
Ref gh-4395
Ref gh-4406
3.x-stableversion of this PR: #5260+34 bytes
Checklist