🌐 AI搜索 & 代理 主页
Skip to content

CSS: Make the reliableTrDimensions support test work with Bootstrap CSS (3.x version) #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Jul 10, 2023
Merged

CSS: Make the reliableTrDimensions support test work with Bootstrap CSS (3.x version) #5279

mgol merged 1 commit into from
Jul 10, 2023

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jun 26, 2023 •
edited
Loading

Summary

3.x version of PR #5278.

Bootstrap 5 includes the following CSS on the page:

*,
*::before,
*::after {
  box-sizing: border-box;
}

That threw our reliableTrDimensions support test off. This change fixes the support test and adds a unit test ensuring support test values on a page including Bootstrap 5 CSS are the same as on a page without it.

Fixes gh-5270
Ref gh-5278

+8 bytes

Checklist

@mgol mgol added CSS Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Jun 26, 2023
@mgol mgol added this to the 3.7.1 milestone Jun 26, 2023
@mgol mgol self-assigned this Jun 26, 2023
This was referenced Jun 26, 2023
Merged
Closed
@mgol mgol changed the title CSS: Make the reliableTrDimensions support test work with Bootstrap CSS CSS: Make the reliableTrDimensions support test work with Bootstrap CSS (3.x version) Jun 26, 2023
@mgol mgol force-pushed the 3.x-tr-height-fix branch from 8fea6a7 to 90d30bd Compare June 26, 2023 21:45
mgol added a commit to mgol/jquery that referenced this pull request Jun 26, 2023
@mgol
CSS: Make the reliableTrDimensions support test work with Bootstrap CSS
81de992 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS is the same as on a page without it.

Fixes jquerygh-5270
Ref jquerygh-5279
mgol added a commit to mgol/jquery that referenced this pull request Jun 29, 2023
@mgol
CSS: Make the reliableTrDimensions support test work with Bootstrap CSS
7fbf15f 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS is the same as on a page without it.

Fixes jquerygh-5270
Ref jquerygh-5279
@mgol mgol force-pushed the 3.x-tr-height-fix branch from 90d30bd to b57bd18 Compare June 29, 2023 15:22
@mgol mgol linked an issue Jun 30, 2023 that may be closed by this pull request
Breaking change on height(Upgrading from 3.5.1 to 3.6/3.7) #5270
Closed
@mgol
CSS: Make the reliableTrDimensions support test work with Bootstrap CSS
26b3cc2 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS are the same as on a page without it.

Fixes jquerygh-5270
Ref jquerygh-5278
mgol added a commit to mgol/jquery that referenced this pull request Jul 7, 2023
@mgol
CSS: Make the reliableTrDimensions support test work with Bootstrap CSS
aad9c0f 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS are the same as on a page without it.

Fixes jquerygh-5270
Ref jquerygh-5279
@mgol mgol force-pushed the 3.x-tr-height-fix branch from b57bd18 to 26b3cc2 Compare July 7, 2023 10:16
@angeljqv
Copy link

angeljqv commented Jul 7, 2023

Great! 👍

timmywil
timmywil approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.

@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Jul 10, 2023
@mgol mgol merged commit a288838 into jquery:3.x-stable Jul 10, 2023
@mgol mgol deleted the 3.x-tr-height-fix branch July 10, 2023 16:26
@mgol mgol removed the Needs review label Jul 10, 2023
mgol added a commit to mgol/jquery that referenced this pull request Jul 10, 2023
@mgol
CSS: Make the reliableTrDimensions support test work with Bootstrap CSS
60eacd9 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS are the same as on a page without it.

Fixes jquerygh-5270
Ref jquerygh-5279
mgol added a commit that referenced this pull request Jul 10, 2023
@mgol
CSS: Make the reliableTrDimensions support test work with Bootstrap CSS
65b8503 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS are the same as on a page without it.

Fixes gh-5270
Closes gh-5278
Ref gh-5279
@angeljqv
Copy link

angeljqv commented Jul 10, 2023

Hi, 3.7.1 release date??

@mgol
Copy link
Member Author

mgol commented Jul 10, 2023

@angeljqv there are no blockers for the release now, so we'll release when we have a moment. We never promise specific dates, though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

CSS

Milestone

3.7.1

Development

Successfully merging this pull request may close these issues.

Breaking change on height(Upgrading from 3.5.1 to 3.6/3.7)

3 participants

@mgol @angeljqv @timmywil