CSS:Selector: Align with 3.x, remove the outer selector.js wrapper
#5295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Size impact: |
timmywil
approved these changes
Sep 19, 2023
Member
|
Pending conflict resolution |
Bring some changes from `3.x-stable`: * rename `rtrim` to `rtrimCSS` to distinguish from the previous `rtrim` regex used for `jQuery.trim` * backport one `id` selector test that avoids the selector engine path * remove the inner function wrapper from `selector.js` by renaming the imported `document.js` value The changes also improve the size a little.
Core tests had a spy set up for `jQuery.error` that wasn't cleaned up, influencing Selector tests when all were run together.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring some changes from
3.x-stable:rtrimtortrimCSSto distinguish from the previousrtrimregex used forjQuery.trimidselector test that avoids the selector engine pathselector.jsby renaming the importeddocument.jsvalueThe changes also improve the size a little.
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com