🌐 AI搜索 & 代理 主页
Skip to content

Tests: reuse browser workers in BrowserStack tests #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timmywil merged 6 commits into from
Mar 5, 2024
Merged

Tests: reuse browser workers in BrowserStack tests #5428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d31db3
Tests: reuse browser workers in BrowserStack tests
timmywil Mar 2, 2024
aea5039
Tests: use minutes in acknowledge timeout message
timmywil Mar 4, 2024
da3540c
fixup! PR feedback
timmywil Mar 5, 2024
2b6f86d
fixup! amd -> back to esm
timmywil Mar 5, 2024
8c9b629
fixup! more PR feedback
timmywil Mar 5, 2024
70e31ce
fixup! enable strict mode for yargs command; fix npm test
timmywil Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! amd -> back to esm
  • Loading branch information
@timmywil
timmywil committed Mar 5, 2024
commit 2b6f86d65d4752ae6437f1011a12ad254c1a1297
6 changes: 3 additions & 3 deletions test/runner/lib/buildTestUrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { generateModuleId } from "./generateHash.js";

export function buildTestUrl( modules, { amd, browserstack, jsdom, port, reportId } ) {
export function buildTestUrl( modules, { browserstack, esm, jsdom, port, reportId } ) {
if ( !port ) {
throw new Error( "No port specified." );
}
Expand All @@ -10,8 +10,8 @@ export function buildTestUrl( modules, { amd, browserstack, jsdom, port, reportI
query.append( "moduleId", generateModuleId( module ) );
}

if ( amd ) {
query.append( "amd", "true" );
if ( esm ) {
query.append( "esmodules", "true" );
}

if ( jsdom ) {
Expand Down
4 changes: 2 additions & 2 deletions test/runner/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ const EXIT_HOOK_WAIT_TIMEOUT = 60 * 1000;
* Run modules in parallel in different browser instances.
*/
export async function run( {
amd,
browsers: browserNames,
browserstack,
concurrency,
debug,
esm,
headless,
isolate,
modules = [],
Expand Down Expand Up @@ -242,8 +242,8 @@ export async function run( {
reports[ reportId ] = { browser, headless, modules };

const url = buildTestUrl( modules, {
amd,
browserstack,
esm,
jsdom: browser.browser === "jsdom",
port,
reportId
Expand Down