Tests: Run tests on both real Firefox ESRs #5547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023
timmywil
approved these changes
Sep 5, 2024
Member
timmywil
left a comment
There was a problem hiding this comment.
This looks good, and has the benefit of not having to explicitly set the ESR version.
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 6, 2024
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Contrary to what we did in jquerygh-5547, still run tests on Firefox 115 on BrowserStack - on `main`, we deleted it since we support only the versions supported upstream. In jQuery 3.x, we're testing on all versions matching ESR lines starting with Firefox 48, so for consistency let's keep Firefox 115 there as well. Ref jquerygh-5547
Member
Author
|
|
mgol
added a commit
that referenced
this pull request
Sep 6, 2024
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Contrary to what we did in gh-5547, still run tests on Firefox 115 on BrowserStack - on `main`, we deleted it since we support only the versions supported upstream. In jQuery 3.x, we're testing on all versions matching ESR lines starting with Firefox 48, so for consistency let's keep Firefox 115 there as well. Closes gh-5548 Ref gh-5547
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Oct 9, 2024
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Ref jquery/jquery#5547
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Oct 28, 2024
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Ref jquery/jquery#5547
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Apr 28, 2025
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Ref jquery/jquery#5547
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
May 4, 2025
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Ref jquery/jquery#5547
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
May 5, 2025
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Ref jquery/jquery#5547
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
May 12, 2025
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Ref jquery/jquery#5547
mgol
added a commit
to jquery/jquery-migrate
that referenced
this pull request
May 27, 2025
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Closes gh-582 Ref jquery/jquery#5547
mgol
added a commit
to jquery/jquery-migrate
that referenced
this pull request
May 27, 2025
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Contrary to what we did on `main`, still run tests on Firefox 115 on BrowserStack - on `main`, we deleted it since we support only the versions supported upstream. In jQuery Migrate 3.x, we're testing on all versions matching ESR lines starting with Firefox 48, so for consistency let's keep Firefox 115 there as well. Closes gh-582 Ref jquery/jquery#5547 (cherry picked from commit 41d038b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Example test runs:
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com