🌐 AI搜索 & 代理 主页
Skip to content

Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Nov 5, 2024
Merged

Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters #5570

mgol merged 1 commit into from
Nov 5, 2024

Conversation

@mgol
Copy link
Member

@mgol mgol commented Oct 16, 2024 •
edited
Loading

Summary

Those APIs have formally been deprecated since 3.0.0, but they never made its way into the deprecated module.

Ref gh-5580

PR for main: #5580

Note: this PR only makes sense in its form if we decide to release it as 3.8.0; otherwise, we should avoid moving stuff between modules.

Checklist

@mgol mgol added Selector Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Oct 16, 2024
@mgol mgol self-assigned this Oct 16, 2024
@mgol mgol mentioned this pull request Oct 16, 2024
Closed
1 task
@mgol mgol force-pushed the 3.x-selector-filters-deprecation branch from 5d5fa8f to ddc114e Compare October 16, 2024 23:44
@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Nov 4, 2024
mgol added a commit to mgol/jquery that referenced this pull request Nov 4, 2024
@mgol
Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters
1017e57 
Those APIs have formally been deprecated since `3.0.0`, but they never made its
way into the deprecated module.

`jQuery.expr[ ":" ]` has been removed when Sizzle got inlined into Core in
jquerygh-4395; this change restores it.

Ref jquerygh-5570
Ref jquerygh-4395
@mgol mgol force-pushed the 3.x-selector-filters-deprecation branch from ddc114e to 24d3e6b Compare November 4, 2024 17:53
@mgol mgol added this to the 3.7.2 milestone Nov 4, 2024
@mgol mgol mentioned this pull request Nov 4, 2024
Merged
2 tasks
@mgol mgol force-pushed the 3.x-selector-filters-deprecation branch from 24d3e6b to d160bee Compare November 4, 2024 17:55
@mgol
Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters
26b0092 
Those APIs have formally been deprecated since `3.0.0`, but they never made its
way into the deprecated module.

Ref jquerygh-5580
@mgol mgol force-pushed the 3.x-selector-filters-deprecation branch from d160bee to 26b0092 Compare November 4, 2024 18:03
mgol added a commit that referenced this pull request Nov 4, 2024
@mgol
Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters
329661f 
Those APIs have formally been deprecated since `3.0.0`, but they never made its
way into the deprecated module.

`jQuery.expr[ ":" ]` has been removed when Sizzle got inlined into Core in
gh-4395; this change restores it.

Closes gh-5580
Ref gh-5570
Ref gh-4395
@mgol mgol requested a review from timmywil November 4, 2024 23:00
@mgol mgol merged commit 5eab9df into jquery:3.x-stable Nov 5, 2024
17 checks passed
@mgol mgol deleted the 3.x-selector-filters-deprecation branch November 5, 2024 22:09
@mgol mgol removed the Needs review label Nov 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

Selector

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil