🌐 AI搜索 & 代理 主页
Skip to content

Slider: Add touch event support for better mobile interaction #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikunj8866 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Slider: Add touch event support for better mobile interaction #2362

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3670091
add touch event support for mobile interaction
nikunj8866 Jul 23, 2025
4222b13
fix linting failures
nikunj8866 Aug 7, 2025
8d07369
Merge branch 'jquery:main' into 2361-add-touch-event-support-for-bett…
nikunj8866 Sep 9, 2025
ce17d0d
Build: Bump github/codeql-action in the github-actions group
dependabot[bot] Aug 6, 2025
0fcab4c
Build: Test on jQuery 4.0.0-rc.1
mgol Aug 12, 2025
ea2f0fa
Tests: Make tests not trigger Migrate 4.0.0-beta.1 warnings
mgol Aug 18, 2025
8785ca9
Build: Fix tests on Edge
mgol Aug 18, 2025
f49700b
Merge branch '2361-add-touch-event-support-for-better-mobile-interact…
nikunj8866 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tests: Make tests not trigger Migrate 4.0.0-beta.1 warnings 
Changes:
* Checkboxradio: Change `.attr( "checked", true )` to
  `.attr( "checked", "checked" )
* Selectmenu: Disable the `boolean-attributes` patch for one assertion where
  it's impossible to avoid

Closes gh-2364
  • Loading branch information
@mgol @nikunj8866
mgol authored and nikunj8866 committed Sep 9, 2025
commit ea2f0fa0d8c16e23369582da9c9d9f3debf86a4f
2 changes: 1 addition & 1 deletion tests/unit/checkboxradio/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ QUnit.test( "icon - default unchecked", function( assert ) {
} );

QUnit.test( "icon - default checked", function( assert ) {
var checkbox = $( "#checkbox-option-icon" ).attr( "checked", true );
var checkbox = $( "#checkbox-option-icon" ).attr( "checked", "checked" );

assert.expect( 2 );

Expand Down
21 changes: 19 additions & 2 deletions tests/unit/selectmenu/methods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,25 @@ QUnit.test( "enable / disable", function( assert ) {

element.selectmenu( "disable" );
assert.ok( element.selectmenu( "option", "disabled" ), "disable: widget option" );
assert.ok( [ "disabled", "" ].indexOf( element.attr( "disabled" ) ) !== -1,
"disable: native select disabled" );

// Migrate 4.x warns about reading boolean attributes when their
// value is not their lowercase name - but that's what happens
// when setting the `disabled` property to `true` first; the attribute
// is then set to an empty string. Avoid the warning by temporarily
// disabling the patch.
// In real apps it's discouraged to mix `.prop()` & `.attr()` usage
// for reflected property-attribute pairs.
if ( $.migrateDisablePatches ) {
$.migrateDisablePatches( "boolean-attributes" );
}
assert.ok(
[ "disabled", "" ].indexOf( element.attr( "disabled" ) ) !== -1,
"disable: native select disabled"
);
if ( $.migrateEnablePatches ) {
$.migrateEnablePatches( "boolean-attributes" );
}

assert.equal( button.attr( "aria-disabled" ), "true", "disable: button ARIA" );
assert.equal( button.attr( "tabindex" ), -1, "disable: button tabindex" );
assert.equal( menu.attr( "aria-disabled" ), "true", "disable: menu ARIA" );
Expand Down