Build: Improve eslint configuration, changed location and setTimeout

- Re-indented some comments and code after added eslint - Changed location and setTimeout for window.location and window.setTimeout. fix: #438
jquery · JuanMaRuiz · Jan 20, 2019 · Jan 20, 2019 · Jan 20, 2019 · Jan 20, 2019
commit 7c3f27e12e82aa3e301dc37ebd3f9136cbbc2d66
diff --git a/dist/.eslintrc.json b/dist/.eslintrc.json
@@ -6,7 +6,7 @@
 		// That is okay for the built version
 		"no-multiple-empty-lines": "off",
 
-		// Sizzle is not compatible with jQuery code style
+		// Too many violations.
 		"no-nested-ternary": "off"
 	}
 }
diff --git a/dist/sizzle.js b/dist/sizzle.js
@@ -6,7 +6,7 @@
  * Released under the MIT license
  * https://js.foundation/
  *
- * Date: 2019-05-27
+ * Date: 2019-05-28
  */
 ( function( window ) {
 var i,
@@ -215,21 +215,21 @@ try {
 } catch ( e ) {
 	push = { apply: arr.length ?
 
-			// Leverage slice if possible
-			function( target, els ) {
-				pushNative.apply( target, slice.call( els ) );
-			} :
+		// Leverage slice if possible
+		function( target, els ) {
+			pushNative.apply( target, slice.call( els ) );
+		} :
 
-			// Support: IE<9
-			// Otherwise append directly
-			function( target, els ) {
-				var j = target.length,
-					i = 0;
+		// Support: IE<9
+		// Otherwise append directly
+		function( target, els ) {
+			var j = target.length,
+				i = 0;
 
-				// Can't trust NodeList.length
-				while ( ( target[ j++ ] = els[ i++ ] ) ) {}
-				target.length = j - 1;
-			}
+			// Can't trust NodeList.length
+			while ( ( target[ j++ ] = els[ i++ ] ) ) {}
+			target.length = j - 1;
+		}
 	};
 }
 
@@ -531,9 +531,9 @@ function createDisabledPseudo( disabled ) {
 
 			return elem.disabled === disabled;
 
-			// Try to winnow out elements that can't be disabled before trusting the disabled property.
-			// Some victims get caught in our net (label, legend, menu, track), but it shouldn't
-			// even exist on them, let alone have a boolean value.
+		// Try to winnow out elements that can't be disabled before trusting the disabled property.
+		// Some victims get caught in our net (label, legend, menu, track), but it shouldn't
+		// even exist on them, let alone have a boolean value.
 		} else if ( "label" in elem ) {
 			return elem.disabled === disabled;
 		}
@@ -620,7 +620,7 @@ if ( doc === document || doc.nodeType !== 9 ) {
 		if ( subWindow.addEventListener ) {
 			subWindow.addEventListener( "unload", unloadHandler, false );
 
-			// Support: IE 9 - 10 only
+		// Support: IE 9 - 10 only
 		} else if ( subWindow.attachEvent ) {
 			subWindow.attachEvent( "onunload", unloadHandler );
 		}
@@ -719,7 +719,7 @@ if ( doc === document || doc.nodeType !== 9 ) {
 			if ( typeof context.getElementsByTagName !== "undefined" ) {
 				return context.getElementsByTagName( tag );
 
-				// DocumentFragment nodes don't have gEBTN
+			// DocumentFragment nodes don't have gEBTN
 			} else if ( support.qsa ) {
 				return context.querySelectorAll( tag );
 			}
@@ -977,7 +977,7 @@ if ( doc === document || doc.nodeType !== 9 ) {
 									( indexOf( sortInput, a ) - indexOf( sortInput, b ) ) :
 									0;
 
-				// If the nodes are siblings, we can do a quick check
+			// If the nodes are siblings, we can do a quick check
 			} else if ( aup === bup ) {
 				return siblingCheck( a, b );
 			}
@@ -1704,7 +1704,7 @@ Expr = Sizzle.selectors = {
 	}
 };
 
-Expr.pseudos.nth = Expr.pseudos.eq;
+Expr.pseudos[ "nth" ] = Expr.pseudos[ "eq" ];
 
 // Add button/input type pseudos
 for ( i in { radio: true, checkbox: true, file: true, password: true, image: true } ) {
@@ -1994,7 +1994,7 @@ function setMatcher( preFilter, selector, matcher, postFilter, postFinder, postS
 				}
 			}
 
-			// Add elements to results, through postFinder if defined
+		// Add elements to results, through postFinder if defined
 		} else {
 			matcherOut = condense(
 				matcherOut === results ?
@@ -2305,29 +2305,29 @@ select = Sizzle.select = function( selector, context, results, seed ) {
 	return results;
 };
 
-// One-time assignments
+	// One-time assignments
 
-// Sort stability
+	// Sort stability
 	support.sortStable = expando.split( "" ).sort( sortOrder ).join( "" ) === expando;
 
-// Support: Chrome 14-35+
-// Always assume duplicates if they aren't passed to the comparison function
+	// Support: Chrome 14-35+
+	// Always assume duplicates if they aren't passed to the comparison function
 	support.detectDuplicates = !!hasDuplicate;
 
-// Initialize against the default document
+	// Initialize against the default document
 	setDocument();
 
-// Support: Webkit<537.32 - Safari 6.0.3/Chrome 25 (fixed in Chrome 27)
-// Detached nodes confoundingly follow *each other*
+	// Support: Webkit<537.32 - Safari 6.0.3/Chrome 25 (fixed in Chrome 27)
+	// Detached nodes confoundingly follow *each other*
 	support.sortDetached = assert( function( el ) {
 
 		// Should return 1, but returns 4 (following)
 		return el.compareDocumentPosition( document.createElement( "fieldset" ) ) & 1;
 	} );
 
-// Support: IE<8
-// Prevent attribute/property "interpolation"
-// https://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx
+	// Support: IE<8
+	// Prevent attribute/property "interpolation"
+	// https://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx
 	if ( !assert( function( el ) {
 		el.innerHTML = "<a href='#'></a>";
 		return el.firstChild.getAttribute( "href" ) === "#";
@@ -2339,8 +2339,8 @@ select = Sizzle.select = function( selector, context, results, seed ) {
 		} );
 	}
 
-// Support: IE<9
-// Use defaultValue in place of getAttribute("value")
+	// Support: IE<9
+	// Use defaultValue in place of getAttribute("value")
 	if ( !support.attributes || !assert( function( el ) {
 		el.innerHTML = "<input/>";
 		el.firstChild.setAttribute( "value", "" );
@@ -2353,8 +2353,8 @@ select = Sizzle.select = function( selector, context, results, seed ) {
 		} );
 	}
 
-// Support: IE<9
-// Use getAttributeNode to fetch booleans when getAttribute lies
+	// Support: IE<9
+	// Use getAttributeNode to fetch booleans when getAttribute lies
 	if ( !assert( function( el ) {
 		return el.getAttribute( "disabled" ) == null;
 	} ) ) {
@@ -2369,7 +2369,7 @@ select = Sizzle.select = function( selector, context, results, seed ) {
 		} );
 	}
 
-// EXPOSE
+	// EXPOSE
 	var _sizzle = window.Sizzle;
 
 	Sizzle.noConflict = function() {
@@ -2385,7 +2385,7 @@ select = Sizzle.select = function( selector, context, results, seed ) {
 			return Sizzle;
 		} );
 
-// Sizzle requires that there be a global window in Common-JS like environments
+	// Sizzle requires that there be a global window in Common-JS like environments
 	} else if ( typeof module !== "undefined" && module.exports ) {
 		module.exports = Sizzle;
 	} else {

diff --git a/dist/sizzle.min.map b/dist/sizzle.min.map
diff --git a/package.json b/package.json
@@ -64,7 +64,6 @@
     "requirejs-text": "2.0.15"
   },
   "scripts": {
-    "lint": "grunt eslint",
     "build": "npm install && grunt",
     "start": "grunt start",
     "test": "grunt test"

diff --git a/speed/.eslintrc.json b/speed/.eslintrc.json
@@ -3,8 +3,6 @@
 	"globals": {
 		"console":  true,
 		"require": true,
-		"setTimeout": true,
-		"location": true,
 		"window": true
 	}
 }
diff --git a/speed/speed.js b/speed/speed.js
@@ -39,7 +39,7 @@ function( Benchmark, document, selectors ) {
 		urlParams = ( function() {
 			var parts, value,
 				params = {},
-				search = location.search.substring( 1 ).split( "&" ),
+				search = window.location.search.substring( 1 ).split( "&" ),
 				i = 0,
 				len = search.length;
 
@@ -387,7 +387,7 @@ function( Benchmark, document, selectors ) {
 		index = callbacks.push( function() {
 			var self = this,
 				args = arguments;
-			setTimeout( function() {
+			window.setTimeout( function() {
 				test.apply( self, args );
 			}, 0 );
 		} ) - 1;

diff --git a/src/sizzle.js b/src/sizzle.js
@@ -215,21 +215,21 @@ try {
 } catch ( e ) {
 	push = { apply: arr.length ?
 
-			// Leverage slice if possible
-			function( target, els ) {
-				pushNative.apply( target, slice.call( els ) );
-			} :
-
-			// Support: IE<9
-			// Otherwise append directly
-			function( target, els ) {
-				var j = target.length,
-					i = 0;
+		// Leverage slice if possible
+		function( target, els ) {
+			pushNative.apply( target, slice.call( els ) );
+		} :
 
-				// Can't trust NodeList.length
-				while ( ( target[ j++ ] = els[ i++ ] ) ) {}
-				target.length = j - 1;
-			}
+		// Support: IE<9
+		// Otherwise append directly
+		function( target, els ) {
+			var j = target.length,
+				i = 0;
+
+			// Can't trust NodeList.length
+			while ( ( target[ j++ ] = els[ i++ ] ) ) {}
+			target.length = j - 1;
+		}
 	};
 }
 
@@ -1704,7 +1704,7 @@ Expr = Sizzle.selectors = {
 	}
 };
 
-Expr.pseudos.nth = Expr.pseudos.eq;
+Expr.pseudos[ "nth" ] = Expr.pseudos[ "eq" ];
 
 // Add button/input type pseudos
 for ( i in { radio: true, checkbox: true, file: true, password: true, image: true } ) {

diff --git a/test/.eslintrc b/test/.eslintrc
@@ -35,6 +35,8 @@
 
 		// Not really too many - waiting for autofix features for these rules
 		"lines-around-comment": "off",
+
+		// Turned off for compatibility with Google Closure Compiler's advanced mode
 		"dot-notation": "off"
 	}
 }