Refactor API group validation and error reporting #133466
Open
+44
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 11 10:25:10 UTC 2025. |
b31e476 to
15c6e61
Compare
Contributor
Author
|
/test pull-kubernetes-integration |
15c6e61 to
b61da1f
Compare
Contributor
Author
|
/test pull-kubernetes-integration |
Contributor
Author
b61da1f to
b82fd7a
Compare
1d77400 to
b169e8b
Compare
Contributor
Author
|
/test pull-kubernetes-integration |
Contributor
Author
|
/retest |
Contributor
|
/triage accepted |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Contributor
|
/remove-lifecycle stale /assign @siyuanfoundation Can we move forward this? @siyuanfoundation, please reassign if you don't want to or can't review. |
staging/src/k8s.io/apiserver/pkg/server/options/api_enablement.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/server/resourceconfig/helpers.go
Outdated
Show resolved
Hide resolved
b169e8b to
8489bbc
Compare
liggitt
reviewed
Nov 19, 2025
staging/src/k8s.io/apiserver/pkg/server/options/api_enablement.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/server/options/api_enablement.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/server/options/api_enablement.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/server/resourceconfig/helpers.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/server/resourceconfig/helpers.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/server/resourceconfig/helpers.go
Outdated
Show resolved
Hide resolved
8230dc7 to
ab72796
Compare
liggitt
reviewed
Nov 20, 2025
| if len(groups) != 0 { | ||
| errors = append(errors, fmt.Errorf("unknown api groups %s", strings.Join(groups, ","))) | ||
| if len(unknownGroupVersions) != 0 { | ||
| errors = append(errors, fmt.Errorf("unknown api groups %s", strings.Join(unknownGroupVersions.UnsortedList(), ","))) |
Member
There was a problem hiding this comment.
use sets.List(unknownGroupVersions)
Contributor
Author
|
/retest |
Updated API group validation logic to improve error reporting. The Validate method now provides more descriptive error messages when unknown API groups are encountered. Unit test cases are updated to match the new error messages. Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
ab72796 to
392bb8e
Compare
Member
|
/lgtm |
Contributor
|
LGTM label has been added. Git tree hash: 406eeabac413ebc4db076297a0c97f39ab96666f
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a fix for validation error messages produced by the
APIEnablementOptions.Validate. Error message for unknown API groups didn't contain versions, which could be confusing. Here is an example of the latest one from this failing ci-node-e2e-crio-cgrpv2-dra-1-34 job:F0810 13:37:19.210421 2969 services.go:119] Failed to run e2e services: failed to validate ServerRunOptions: unknown api groups api. With this fix the error would be more descriptive and easier to understand:Failed to run e2e services: failed to validate ServerRunOptions: unknown api groups api/stable1Updated API group validation logic to improve error reporting. The Validate method now checks for unknown API groups using group versions and provides more descriptive error messages when invalid or unknown API groups are encountered.
Unit test cases are updated to match the new error messages.
Which issue(s) this PR is related to:
#133460
Does this PR introduce a user-facing change?