Drop unnecessary usegocmp build tag
#133828
Open
+0
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/assign @liggitt |
Member
Author
|
/sig architecture |
238566d to
139726b
Compare
139726b to
e067f02
Compare
Member
|
happy to see this get cleaned up, but maaaaaybe let's wait until the folks who build servers on top of k8s.io/apiserver have a chance to pull in 1.34 and do a build / release cycle before we delete this cc @deads2k |
Member
Author
|
/hold per last comment from @liggitt |
Member
|
/triage accepted |
Member
Author
|
will get back to it, no rush! |
Member
Author
|
it's been a while :) reopening! |
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
e067f02 to
1f1d197
Compare
Member
Author
|
/hold cancel |
Member
Author
Member
|
/lgtm |
Contributor
|
LGTM label has been added. Git tree hash: fb8d0475d16fc58d1fe90e017bf20d6cb7c8c6b3
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
usegocmpin #132221 as a safety measure just in case we needed to flip back to older implementation using"github.com/google/go-cmp/cmp". So far we haven't needed it. So let's remove it.What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: