🌐 AI搜索 & 代理 主页
Skip to content

Add context-aware unfinishedWork loop #134716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gurjaspreet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add context-aware unfinishedWork loop #134716

gurjaspreet wants to merge 1 commit into from
+27 −0

Conversation

@gurjaspreet
Copy link

@gurjaspreet gurjaspreet commented Oct 19, 2025 •
edited
Loading

  • Introduced updateUnfinishedWorkLoopWithContext to allow graceful shutdown and context cancellation in workqueue background processing.
  • Uses klog.FromContext(ctx) for structured logging.

Fixes/References: #126379

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR improves the workqueue implementation by adding a context-aware version of the updateUnfinishedWorkLoop.
This allows:

  • Proper cancellation of background loops using context.Context.
  • Structured logging with klog.FromContext(ctx).

Which issue(s) this PR is related to:

Fixes #126379

Special notes for your reviewer:

  • The existing updateUnfinishedWorkLoop remains unchanged for backward compatibility.
  • No functional change to queue processing; this affects only background monitoring of unfinished work.

Does this PR introduce a user-facing change?

Added a context-aware update loop in workqueue for graceful shutdown and structured logging using klog.FromContext.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@gurjaspreet
add context-aware unfinishedWork loop
5e62aed 
- Introduced updateUnfinishedWorkLoopWithContext to allow graceful shutdown
  and context cancellation in workqueue background processing.
- Uses klog.FromContext(ctx) for structured logging.

Fixes/References: kubernetes#126379
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 19, 2025

Welcome @gurjaspreet!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 19, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 19, 2025

Hi @gurjaspreet. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 19, 2025
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gurjaspreet
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gurjaspreet
Copy link
Author

gurjaspreet commented Oct 21, 2025

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 21, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@yliaog yliaog Awaiting requested review from yliaog

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add and use alternative APIs which support contextual logging

2 participants

@gurjaspreet @k8s-ci-robot